Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps:run test with lengthy output -- don't log actual output on failure #2

Open
Cryptophobia opened this issue Mar 21, 2018 · 1 comment
Labels

Comments

@Cryptophobia
Copy link
Member

From @vdice on May 26, 2017 22:17

When/if this apps:run test fails, the Expect statement proceeds to log the entire command's output, corrupting the user's terminal and crowding out logs with byte code.

We should re-jigger the test, perhaps checking first if the byte array does not match expected (outside of Expect) and then, if not, logging some standard error/failure message accordingly.

Copied from original issue: deis/workflow-e2e#360

@Cryptophobia
Copy link
Member Author

From @vdice on May 31, 2017 0:3

Alas, since the output is stored in sess.Out.ContentsI(), Ginkgo will log this anytime the test fails (no matter how test is failed). Wondering if there's another way to eliminate logging of output? Or, another way to test this case? ping @mboersma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant