Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Android port back to winit as well #670

Open
1 of 2 tasks
wusyong opened this issue Jan 10, 2023 · 1 comment
Open
1 of 2 tasks

Switch Android port back to winit as well #670

wusyong opened this issue Jan 10, 2023 · 1 comment
Labels

Comments

@wusyong
Copy link
Member

wusyong commented Jan 10, 2023

Is your feature request related to a problem? Please describe.
Our current implementation is quite different than winit before because winit creates NativeActivity for its application and it's limited when it wants to use several Android API. So we just implement our own custom Activity and bind functions ourselves. This of course creates a workload to maintain android port ourselves.

Describe the solution you'd like
Since winit now adopts android-activity, we can consider switching back to it. android-activity supports another GameActivity which basically inherits AppCompatActivity. We can inherit GameActivity instead in our custom Activity, while keeping binding functions through tao-macros.

Describe alternatives you've considered
While this sounds possible, switching back all over again is definitely a huge task and there are still a few uncertainties. We could just still stick to our own implementation.

Would you want to assign yourself to implement this feature?

  • Yes
  • No

Additional context
Here's the issue in android-activity: rust-mobile/android-activity#57

@amrbashir
Copy link
Member

It would be ideal to add just the base AppCompatActivity directly into android-activity crate along with GameActivity and NativeActivity so we use only what we need because sounds to me that GameActivity has extra functionality that we don't need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📬Proposal
Development

No branches or pull requests

2 participants