Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect incompatibility with Sponge #102

Open
gabizou opened this issue Jan 20, 2025 · 0 comments
Open

Redirect incompatibility with Sponge #102

gabizou opened this issue Jan 20, 2025 · 0 comments

Comments

@gabizou
Copy link

gabizou commented Jan 20, 2025

In aiming to achieve better compatibility with other mods, Sponge has been replacing various @Redirects with @WrapOperations. This leads to greater user experience when they throw our mods together (like in NeoForge). Otherwise, if Sponge moves to using WrapOperation, there's no way Sponge's event tracking system will work when Observable is installed.

I've went and made a branch of Sponge to begin testing with the WrapOperation changes to see if this will be sufficient, once Observable switches over to using the same annotation for its own functionality.

For what it's worth, this is discovered from SpongePowered/Sponge#4165 's investigation. It seems likely that the PR that rearchitects some of Sponge's injection points to avoid collisions is "working" with observable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant