Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for pending could be reported #22

Open
marcusreese opened this issue Mar 10, 2017 · 0 comments
Open

Reason for pending could be reported #22

marcusreese opened this issue Mar 10, 2017 · 0 comments

Comments

@marcusreese
Copy link

marcusreese commented Mar 10, 2017

As the Jasmine docs mention, calling pending('<your reason here>') in a spec causes it not to run.

The reason is being sent to html.jasmine.reporter.js but never printed to the screen.

The fix would be simple. Like the following:

Around line 203:

var description = resultNode.result.description;
var pendingReason = resultNode.result.pendingReason;
var fullDescription = pendingReason ? description + ' (' + pendingReason + ')' : description;

Then on what was line 206, just replace resultNode.result.description with fullDescription.

Would you like to do this? Or would you like me to create a pull request? Or none of the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant