Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix int float conversion warnings #80

Open
drewdzzz opened this issue Dec 12, 2023 · 0 comments
Open

Fix int float conversion warnings #80

drewdzzz opened this issue Dec 12, 2023 · 0 comments
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@drewdzzz
Copy link
Collaborator

After populating compile options with -Wimplicit-int-float-conversion flag the build fails. int is implicitly conversed to float in at least 2 places:

  1. LibevNetProvider.hpp:365 - ev_timer_init(&m_TimeoutWatcher, &timeout_cb, timeout / MILLISECONDS, 0 /* repeat */); in method wait.
  2. Dec.hpp:486 - item = val; in read_item.
@drewdzzz drewdzzz added the code health Improve code readability, simplify maintenance and so on label Dec 12, 2023
@drewdzzz drewdzzz mentioned this issue Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewdzzz