Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the service #5

Open
LeonidVas opened this issue Apr 21, 2021 · 2 comments
Open

Add unit tests for the service #5

LeonidVas opened this issue Apr 21, 2021 · 2 comments

Comments

@LeonidVas
Copy link
Contributor

Now the tests is absent and such code is difficult to develop and maintain.
To test interaction with S3 the "tarantool-test" bucket can be used.

@Totktonada
Copy link
Member

Totktonada commented Apr 26, 2021

How about using minio?

@LeonidVas
Copy link
Contributor Author

I have spent some time thinking about this task, and it's logical to divide this tasks into two:

  • unit tests (can also be divided)
  • integration tests

I propose leaving the unit test part of the work here, and move the integration test part of the work into a separate task.

In the context of this task, I propose to add the following tests:

  • check if the configuration is loaded correctly (including gpg key)
  • implement testing controller and view according to https://flask.palletsprojects.com/en/2.0.x/testing/ . For this, the model must be mocked
  • add testing of model by using minio without checking of the synchronization (this part will be checked by integration tests)

Probably need to change some of the application code while tests will writes. These changes should be as minimal as possible, since there is no guarantee that the correctness of the code will be maintained in the form of tests at this time.

@LeonidVas LeonidVas added teamQ and removed 13sp labels Feb 18, 2022
@LeonidVas LeonidVas changed the title Add tests for the service Add unit tests for the service Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants