Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new error format in ‎arrow/tarantool_test.go / TestInsert_invalid #415

Open
Gumix opened this issue Oct 23, 2024 · 0 comments
Open

Comments

@Gumix
Copy link

Gumix commented Oct 23, 2024

changes the format of the xrow decoding error. Previously the error message was "Failed to decode Arrow IPC data".
Now the top-level error message equals "Invalid MsgPack - packet body" with a chain of nested errors.

So I suggest:

  1. Temporary disable these checks:

{
"",
"Failed to decode Arrow IPC data",
},
{
"00",
"Failed to decode Arrow IPC data",
},

  1. Merge the patch mentioned above to master.

  2. Enable the checks with updated error messages.

oleg-jukovec added a commit that referenced this issue Oct 23, 2024
The pull request changes [1] changes an error message on arrow
decoding. The patch replaces a check of error message to a check
of error code as it is a more stable check. However, the code is
changed too. So as a temporary solution we need to work with both
codes at the same time.

1. tarantool/tarantool#10665

Part of #415
oleg-jukovec added a commit that referenced this issue Oct 24, 2024
The pull request changes [1] changes an error message on arrow
decoding. The patch replaces a check of error message to a check
of error code as it is a more stable check. However, the code is
changed too. So as a temporary solution we need to work with both
codes at the same time.

1. tarantool/tarantool#10665

Part of #415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants