You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two common mistakes that are comparably easy to make and have significant consequences.
Submodule was updated by mistake.
Submodule was updated to a wrong commit that is not in master branch of the submodule.
It would be great if checkpatch could find those mistakes.
Let's introduce a special commit message tag, that shows that submodule update was intended. Something like "UPDATE_SUBMODULE=". Don't allow commits with submodule update without appropriate commit message tags.
Let's check that submodule commit is in master tree. Perhaps it can be done as in tarantool/tools/check_push_master.sh, it should be investigated. And perhaps having done that, check_push_master.sh must be removed.
The text was updated successfully, but these errors were encountered:
In the past, to prevent such kind of problems with committing actual reverts of submodule history, in Yandex.Taxi we started to check that commit updating submodule is actually ancestor, and not predecessor in its' git history. (Without any special commit message and what not)
There are two common mistakes that are comparably easy to make and have significant consequences.
It would be great if checkpatch could find those mistakes.
tarantool/tools/check_push_master.sh
, it should be investigated. And perhaps having done that,check_push_master.sh
must be removed.The text was updated successfully, but these errors were encountered: