Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check submodules' commits #9

Open
alyapunov opened this issue Mar 28, 2022 · 1 comment
Open

Check submodules' commits #9

alyapunov opened this issue Mar 28, 2022 · 1 comment
Labels
feature A new functionality

Comments

@alyapunov
Copy link
Contributor

There are two common mistakes that are comparably easy to make and have significant consequences.

  1. Submodule was updated by mistake.
  2. Submodule was updated to a wrong commit that is not in master branch of the submodule.

It would be great if checkpatch could find those mistakes.

  1. Let's introduce a special commit message tag, that shows that submodule update was intended. Something like "UPDATE_SUBMODULE=". Don't allow commits with submodule update without appropriate commit message tags.
  2. Let's check that submodule commit is in master tree. Perhaps it can be done as in tarantool/tools/check_push_master.sh, it should be investigated. And perhaps having done that, check_push_master.sh must be removed.
@tsafin
Copy link

tsafin commented Mar 29, 2022

In the past, to prevent such kind of problems with committing actual reverts of submodule history, in Yandex.Taxi we started to check that commit updating submodule is actually ancestor, and not predecessor in its' git history. (Without any special commit message and what not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

No branches or pull requests

3 participants