Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or fix withReadTimeout #346

Open
ArtDu opened this issue Jan 20, 2023 · 3 comments
Open

Remove or fix withReadTimeout #346

ArtDu opened this issue Jan 20, 2023 · 3 comments

Comments

@ArtDu
Copy link
Contributor

ArtDu commented Jan 20, 2023

It doesn't do anything right now
@ArtDu ArtDu added the 2sp label Jan 20, 2023
@akudiyar
Copy link
Collaborator

akudiyar commented Feb 2, 2023

It should set a read timeout for a request if I understand correctly what this ticket is about.

@ArtDu
Copy link
Contributor Author

ArtDu commented Feb 20, 2023

For request timeout we have requestTimeout, but read timeout isn't being used in code

@akudiyar
Copy link
Collaborator

The proper solution for this is to use https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/timeout/ReadTimeoutHandler.java. It seems the option was added with that in mind, but the handler was not added.

@TarantoolBot TarantoolBot removed the 2sp label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akudiyar @ArtDu @TarantoolBot