-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String array deserialization #178
Comments
@KGOH Hi there! Sure, will add this (and maybe long arrays) in the next release 👍 In the meantime, please note that you might want to avoid |
v3.5.0 will add read support for native arrays of strings, longs, ints, doubles, and floats. |
@ptaoussanis I briefly glanced at your commits and the class name handling looks good, but just in case: in Clojure 1.12 a new array class syntax was added:
And out of curiosity: as a library developer, do you stick with older Clojure versions to support more projects, or do you always update to the latest version? |
@KGOH Thanks for checking in about this 👍 The new syntax is nice, but I do intentionally keep compatibility with at least the last 3 major version of Clojure. In practice this usually isn't a problem since there's rarely anything super important in newer versions - and it's often possible to use the new stuff conditioned on its availability. Nippy's unit tests currently check against Clojure 1.9, 1.10, 1.11, and 1.12. |
Please add
[Ljava.lang.String;
class to the deserialization listArray of strings serializes more compact
(count (nippy/fast-freeze (into-array String (repeat 1000 "hello")))) #_5071
(count (nippy/fast-freeze (object-array (repeat 1000 "hello")))) #_7005
The text was updated successfully, but these errors were encountered: