From 990d2608c7dce2c3801c2cfd676e5c2e5b74c743 Mon Sep 17 00:00:00 2001 From: Brett Camper Date: Fri, 4 Dec 2020 22:45:22 -0500 Subject: [PATCH] minor cleanup --- src/scene/globals.js | 5 +---- src/scene/scene_loader.js | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/scene/globals.js b/src/scene/globals.js index 7046aac1e..f318f6276 100644 --- a/src/scene/globals.js +++ b/src/scene/globals.js @@ -10,10 +10,7 @@ const GLOBAL_REGISTRY = '__global_prop'; // Property name references a global property? export function isGlobalReference (val) { - if (val && val.slice(0, GLOBAL_PREFIX_LENGTH) === GLOBAL_PREFIX) { - return true; - } - return false; + return val?.slice(0, GLOBAL_PREFIX_LENGTH) === GLOBAL_PREFIX; } // Has object property been substitued with a value from a global reference? diff --git a/src/scene/scene_loader.js b/src/scene/scene_loader.js index 8b11697b6..65d2ddd6b 100644 --- a/src/scene/scene_loader.js +++ b/src/scene/scene_loader.js @@ -281,7 +281,6 @@ const SceneLoader = { if (typeof curValue === 'string' && config.textures[curValue] == null) { if (isGlobalSubstitution(config, path)) { // global substituions are resolved against the base scene path, not the import they came from - // const url = curValue; const url = base_bundle.urlFor(curValue); config.textures[curValue] = { url }; }