Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Electron standalone #4

Closed
parkerlreed opened this issue Feb 5, 2023 · 7 comments
Closed

[Feature request] Electron standalone #4

parkerlreed opened this issue Feb 5, 2023 · 7 comments

Comments

@parkerlreed
Copy link

Describe the solution you'd like

I apologize if I've brought this up in a comment before.

Would be great to have WebADB as more of a standalone application using electron.

It is by far the best ADB toolkit hands down web or not.

Describe alternatives you've considered

Setting WebADB as a Chrome shortcut. Doesn't work with my main browser so I've been having to keep Edge downloaded just for one website.

Additional context

Electron requires the application to call the USB device list itself. There is no native dialog popup like on normal Chrome/Chromium.

https://gist.github.com/jkleinsc/231437c733f6a5ba187c64d53a08cda2

electron/electron#36615

@yume-chan
Copy link
Member

It is by far the best ADB toolkit hands down web or not.

Thank you!

Would be great to have WebADB as more of a standalone application using electron.

Yes, Web is a pretty restricted platform. Being a standalone Electron application can enable many more interesting scenarios, like co-existing with local ADB server/client, connect to devices without user interaction, downloading files will also be much easier.

The only limiting factor is time. I'm pretty busy with my full-time job.

Doesn't work with my main browser

Chrome can create shortcuts for any website, it's in Menu -> More tools -> Create shortcut.... Not sure about other browsers. Relates to yume-chan/ya-webadb#482

Electron requires the application to call the USB device list itself.

No need to worry about that. As mentioned in README (https://github.com/yume-chan/ya-webadb/tree/main/libraries/adb-backend-webusb#use-in-nodejs), in Node.js environment I much prefer the usb package as a drop-in replacement for Chrome/Electron's WebUSB implementation.

@parkerlreed
Copy link
Author

What I was referring to with not working with my main browser is I have Chrome Flatpak and it cannot see USB devices come and go during execution due to the Flatpak sandbox. The only way for it to see the device is to completely close out of the browser and open with the device connected which is not exactly ideal.

Which led to the situation of having to keep an entire extra browser around just for the shortcut.

Thanks for the reply.

@yume-chan yume-chan transferred this issue from yume-chan/ya-webadb Sep 12, 2023
@yume-chan
Copy link
Member

Blocking on electron/forge#2633

I have done some explorations about USB and TCP connection support, but I can't build my project.

@yume-chan
Copy link
Member

The desktop app is now available: https://help.tangoapp.dev/blog/2024/06/05/desktop-app/

@parkerlreed
Copy link
Author

The desktop app is now available: https://help.tangoapp.dev/blog/2024/06/05/desktop-app/

Thank you! The Linux download fails in the browser (Firefox) as a 404 (subsequently clicking the link only downloads the resulting HTML page)

Grabbing from wget worked fine

wget https://app.tangoapp.dev/files/0.1.0/linux/x86-64/tango-bridge

@parkerlreed
Copy link
Author

This is amazing! Finally able to use it in Firefox as the bridge handles TCPIP/USB. Thank you so much!

@rafi16jan
Copy link

Mentioning OP of #618 @garywill and other fellow firefox users, I forked the old ya-webadb and add this little polyfill to enable add websocket device dropdown. Theoretically this enables every browser that supports ws:// or wss://

rafi16jan/ya-webadb@4453255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants