Fix for #49 to help enable NFC #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially forces the user to enable NFC to even be able to enter the passport number etc., but you can't really do anything with the app anyways. So I figured it was better to just forcefully request the user to enable it? It shows the help text in a toast message. Fixes tananaev#49
Because Android Studio was suggesting this
tananaev
reviewed
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to fix #49 and it appears to work ok for me on Galaxy A53 5G (SM-A546B).
This may not be the best way to add this check and help the user to enable NFC, but this is how far my android app dev skills go... :S
This essentially forces the user to enable NFC to even be able to enter
the passport number etc., but you can't really do anything with the app
anyways. So I figured it was better to just forcefully request the user
to enable it?
It shows the help text in a toast message.
Please review this and merge or reject this as you see fit.