feat(protocol): encode proposer address in L2 block header #18770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): encode proposer address in L2 block header
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
|
Yes, the block must be signed and then the pubkey extracted from the message pulled from the p2p then verified that it is signed by a valid preconfer from the registry contract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks, before being proposed on L1, are now shared by the current proposer in Taiko's P2P network. Prior to this PR, there was no way to verify whether an L2 block originated from the current proposer simply by examining the block itself.
However, I realized that this PR does not fully address the issue: a malicious node could still broadcast a block using the current proposer's address in the header.
As a result, this PR will not be merged.
@davidtaikocha It seems in geth, the block must be signed by the preconfer before being broadcasted to p2p.