From da3ae1c3e3986b1ec77d39e2333e9133bd2cb677 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9C=D0=B0=D0=BA=D1=81=D0=B8=D0=BC=20=D0=98=D0=B2=D0=B0?= =?UTF-8?q?=D0=BD=D0=BE=D0=B2?= Date: Tue, 5 Nov 2024 14:12:52 +0300 Subject: [PATCH] chore: explicit run e2e type check (#9668) --- .github/workflows/e2e.yml | 1 + projects/demo-playwright/project.json | 14 +++++--------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index ff306c64c4d6..b273de113708 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,6 +22,7 @@ jobs: continue-on-error: true - uses: taiga-family/ci/actions/setup/node@v1.94.0 + - run: npx nx type-check demo-playwright - name: Building demo-app of git-branch without cache run: npx nx build demo # Don't use prerender please, because it's flaky for e2e diff --git a/projects/demo-playwright/project.json b/projects/demo-playwright/project.json index 43faab445ee0..e86760a55429 100644 --- a/projects/demo-playwright/project.json +++ b/projects/demo-playwright/project.json @@ -14,19 +14,15 @@ "e2e": { "executor": "nx:run-commands", "options": { - "command": "playwright test --config {projectRoot}/playwright.config.ts" - }, - "dependsOn": [ - { - "target": "type-check", - "params": "ignore" - } - ] + "command": "playwright test --config {projectRoot}/playwright.config.ts", + "forwardAllArgs": true + } }, "e2e-ui": { "executor": "nx:run-commands", "options": { - "command": "nx e2e {projectName} -- --ui --debug --update-snapshots" + "command": "playwright test --config {projectRoot}/playwright.config.ts --ui --debug --update-snapshots", + "forwardAllArgs": true } } }