Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolution while adding read-only address is dependent on selected network #3582

Open
beemeeupnow opened this issue Jul 30, 2023 · 1 comment
Assignees
Labels
Type: Bug Something isn't working

Comments

@beemeeupnow
Copy link
Contributor

Discord Discussion Link

No response

What browsers are you seeing the problem on?

Chrome

What were you trying to do?

  • had a custom network selected (e.g. Fantom)
  • went to add a new address
  • in the onboarding tab, selected Read-only address
  • typed a valid ENS/UNS name

What did not work?

Controls change to indicate error state and show Address could not be found

I found that opening the extension while still on the onboarding tab and changing to any of the built-in networks (aside from RSK, which is expected) allows resolution of ENS (and the page automatically updates when you change)

UNS only resolves when either Ethereum or Polygon is selected

I suspect that #2555 plays into this and wanted to note the the current behavior was surprising as a user. (didn't consider the active network since the onboarding tab makes you feel like it should 'just work')

Maybe having the network selector also appear on the read-only address onboarding tab would be good.

Version

None

Relevant log output

No response

@jagodarybacka jagodarybacka added the Type: Bug Something isn't working label Jul 31, 2023
@beemeeupnow
Copy link
Contributor Author

beemeeupnow commented Aug 5, 2023

I will note that the currently selected network also impacts the asset shown next to each address during Ledger onboarding.

Adding a network selection control to the onboarding pages would also address that concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants