If the main image includes multiple base images, a common file in base images causes build failure

[utezduyar]

mkosi commit the issue has been seen with

mkosi 25~devel

Used host distribution

Debian

Used target distribution

Debian

Linux kernel version used

6.1.0-21-amd64

CPU architectures issue was seen on

x86_64

Unexpected behaviour you saw

I have 3 base images, common, device-management and webrtc-streaming. The device-management and webrtc-streaming images are based on common. The main image is based on device-management and webrtc-streaming.
The build fails due to conflict and my guess is that because of the common part of both device-management and webrtc-streaming.

Used mkosi config

$ tree mkosi.conf mkosi.images/
mkosi.conf  [error opening dir]
mkosi.images/
|-- common
|   |-- mkosi.conf
|   `-- mkosi.extra
|       `-- usr
|           `-- lib
|               `-- systemd
|                   `-- system
|                       |-- common.target
|                       `-- default.target -> common.target
|-- device-management
|   |-- mkosi.conf
|   `-- mkosi.extra
|       `-- usr
|           `-- lib
|               `-- systemd
|                   `-- system
|                       |-- default.target -> device-management.target
|                       |-- device-management.target
`-- webrtc-streaming
    |-- mkosi.conf
    `-- mkosi.extra
        `-- usr
            `-- lib
                `-- systemd
                    `-- system
                        |-- default.target -> webrtc-streaming.target
                        `-- webrtc-streaming.target


$ cat mkosi.conf mkosi.images/common/mkosi.conf mkosi.images/device-management/mkosi.conf mkosi.images/webrtc-streaming/mkosi.conf 
[Config]
Dependencies=webrtc-streaming,device-management

[Distribution]
Distribution=debian
Release=unstable

[Output]
OutputDirectory=mkosi.output

[Content]
BaseTrees=%O/webrtc-streaming,%O/device-management

[Build]
ToolsTree=default
[Output]
Format=disk

[Content]
Autologin=true
CleanPackageMetadata=no # important for being able to have delta builds (like systemd system extensions)
Packages=
         systemd
         udev
         ca-certificates
         apt
         vim
         util-linux
         coreutils
         passwd
         login
         binutils
         iproute2
         iputils-ping
[Config]
Dependencies=common

[Output]
Format=disk

[Content]
BaseTrees=%O/common
CleanPackageMetadata=no

BuildPackages=
         golang
[Config]
Dependencies=common

[Output]
Format=disk

[Content]
CleanPackageMetadata=no
BaseTrees=%O/common

mkosi output

File '/work/var/tmp/mkosi-workspace-_p63fmi2/staging/webrtc-streaming.raw' already is of requested size or larger, not growing. (425.4M >= 425.4M)
No changes.
‣ Could not rename /var/tmp/mkosi-workspace-_p63fmi2/staging/webrtc-streaming.raw to /home/umuttl/Development/deleteme-mkosi-bugreport/mkosi.output/webrtc-streaming.raw as they are located on different devices, falling back to copying
‣  /home/umuttl/Development/deleteme-mkosi-bugreport/mkosi.output/webrtc-streaming.raw size is 425.5M, consumes 424.5M.
‣ Building default image
‣  Copying in base trees…
Failed to copy / in image '/work/home/umuttl/Development/deleteme-mkosi-bugreport/mkosi.output/device-management.raw' to '/work/var/tmp/mkosi-workspace-btkvm6x8/root': File exists
‣ "systemd-dissect --copy-from /work/home/umuttl/Development/deleteme-mkosi-bugreport/mkosi.output/device-management.raw / /work/var/tmp/mkosi-workspace-btkvm6x8/root" returned non-zero exit code 1.

[utezduyar]

Attached file (which includes checkout out mkosi binaries too) is the compressed layout of the configuration.
sample.tar.gz

[DaanDeMeyer]

@utezduyar The linked PR should fix your issue.

But please don't use Format=disk for base images, you Format=directory instead. Then you don't have to run everything as root.

[utezduyar]

Thank you. I verified that your patch fixes it by replacing your version of systemd-dissect in mkosi.output/tools. Do you have any tips on how I can proceed while waiting for a new systemd release? I don't want to distribute tools tree with my mkosi.conf. I couldn't find any hooks in Tools*= configs.

Also, thank you for the Format=disk tip. I will change it.

[DaanDeMeyer]

Just changing to Format=directory for your base images will fix the problem as well.