From 0e6d327ce0a9029d6a5de8f37c6c6c069286d67e Mon Sep 17 00:00:00 2001
From: Ravina Dhruve <ravina.dhruve@sysdig.com>
Date: Fri, 12 Apr 2024 14:13:09 -0700
Subject: [PATCH] Make external_id a required var in webhook-datasource module

Change summary:
----------------
The external_id variable was made optional so as to not break
onboarding backend. In the backend, we always ensure passing
the external_id to the module, because if not provided, the
validation for the same would fail via WIF.

Making this required now (as it should be) since backend is all merged.
---
 modules/services/webhook-datasource/README.md    | 2 +-
 modules/services/webhook-datasource/variables.tf | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/modules/services/webhook-datasource/README.md b/modules/services/webhook-datasource/README.md
index 32641c1..f99ed51 100644
--- a/modules/services/webhook-datasource/README.md
+++ b/modules/services/webhook-datasource/README.md
@@ -70,7 +70,7 @@ No modules.
 | <a name="input_project_id"></a> [project\_id](#input\_project\_id) | (Required) Target Project identifier provided by the customer | `string` | n/a | yes |
 | <a name="input_push_endpoint"></a> [push\_endpoint](#input\_push\_endpoint) | (Required) Final endpoint towards which audit logs POST calls will be directed | `string` | n/a | yes |
 | <a name="input_role_name"></a> [role\_name](#input\_role\_name) | (Optional) Role name for custom role binding to the service account, with read permissions for data ingestion resources | `string` | `"SysdigIngestionAuthRole"` | no |
-| <a name="input_external_id"></a> [external\_id](#input\_external\_id) | (Optional) Random string generated unique to a customer | `string` | `""` | no |
+| <a name="input_external_id"></a> [external\_id](#input\_external\_id) | (Required) Random string generated unique to a customer | `string` | n/a | yes |
 | <a name="input_suffix"></a> [suffix](#input\_suffix) | (Optional) Suffix to uniquely identify resources during multiple installs. If not provided, random value is autogenerated | `string` | `null` | no |
 
 ## Outputs
diff --git a/modules/services/webhook-datasource/variables.tf b/modules/services/webhook-datasource/variables.tf
index 894f4ba..7703317 100644
--- a/modules/services/webhook-datasource/variables.tf
+++ b/modules/services/webhook-datasource/variables.tf
@@ -66,8 +66,7 @@ variable "role_name" {
 
 variable "external_id" {
   type        = string
-  description = "Random string generated unique to a customer"
-  default     = ""
+  description = "(Required) Random string generated unique to a customer"
 }
 
 variable "suffix" {