Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about named stoichiometry craziness we don't support #63

Open
luciansmith opened this issue Apr 18, 2022 · 0 comments
Open

Warn about named stoichiometry craziness we don't support #63

luciansmith opened this issue Apr 18, 2022 · 0 comments

Comments

@luciansmith
Copy link
Contributor

Tests 58, 59, and 61 from libsbml flattening don't work in Antimony, because of shenanigans going on with replacements and replaced-by's. Nobody cares about them (yet?) and they've never actually worked in the past when we didn't support named stoichiometries at all, so it's unlikely that anyone will try. But it would be nice if we at least caught the situation and reported a warning.
luciansmith added a commit that referenced this issue Apr 18, 2022
@luciansmith
Allow named stoichiometries to have rules/assignments.
e2cf356 
This makes some obscure older tests fail, but they didn't use to actually work anyway; comment those out, but make a note to at least warn the user about them in #63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luciansmith