Bug for subfolders in matches_snapshot_location

[epenet]

Describe the bug

PyTestLocation.PyTestLocation does not correct take into account sub-folders

syrupy/src/syrupy/location.py

Lines 117 to 121 in e337c88

	def matches_snapshot_location(self, snapshot_location: str) -> bool:
	loc = Path(snapshot_location)
	# "test_file" should match_"test_file.ext" or "test_file/whatever.ext", but not
	# "test_file_suffix.ext"
	return self.basename == loc.stem or self.basename == loc.parent.name

This can be seen on Home Assistant repository, runing pytest --snapshot-details tests/components/config/test_config_entries.py tests/test_config.py will incorrect identify unused snapshots

The structure looks like this:

• /tests/test_config.py
• /tests/snapshots/test_config.ambr
• /tests/test_config_entries.py
• /tests/snapshots/test_config_entries.ambr
• /tests/components/config/test_config_entries.py
• /tests/components/config/snapshots/test_config_entries.ambr

I would expect tests/snapshots/test_config_entries.ambr to be fully ignored, and not to be marked as unused.

[epenet]

Actually, I think the bug comes from the discovery process.
Discovery for /tests/test_config.py should not include /tests/snapshots/test_config_entries.ambr

[epenet]

Well it's very confusing and I'm not sure how best to solve.

• It gets discovered because it is in the snapshot directory for /tests/test_config.py (it loads all snapshot files in directory)
• It gets marked as unused because the name matches for /tests/components/config/test_config_entries.py (it ignores the directory)

I'm not sure how to get around that...

[epenet]

I think the check should be adjusted in the report - maybe looping through the extensions again

https://github.com/syrupy-project/syrupy/blob/e337c888120e7b1d86e8df08181665ebe85fa966/src/syrupy/report.py#L500C9-L500C34

[epenet]

Note: a workaround was implemented in home-assistant/core#129946

But I do believe that:

• pytest tests/folder should discover all files in tests/folder/__snapshots__
• pytest tests/folder/file.py should ONLY discover tests/folder/__snapshots__/file.ambr