Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge: axis names in text mode position reports (contains patch) #489

Open
prof7bit opened this issue Jan 28, 2021 · 1 comment
Open

Edge: axis names in text mode position reports (contains patch) #489

prof7bit opened this issue Jan 28, 2021 · 1 comment

Comments

@prof7bit
Copy link

To whom it may concern,

I have fixed the broken position reporting when in text mode. This has been forgotten when the additional axes were added. Below is a diff against the edge branch:

diff --git a/g2core/canonical_machine.cpp b/g2core/canonical_machine.cpp
index ab26d1b8..c2db78c3 100644
--- a/g2core/canonical_machine.cpp
+++ b/g2core/canonical_machine.cpp
@@ -2525,7 +2525,7 @@ static void _print_axis_coord_flt(nvObj_t *nv, const char *format)
 
 static void _print_pos(nvObj_t *nv, const char *format, uint8_t units)
 {
-    char axes[] = {"XYZABC"};
+    char axes[] = {"XYZUVWABC"};
     uint8_t axis = _axis(nv);
     if (axis >= AXIS_A) { units = DEGREES;}
     sprintf(cs.out_buf, format, axes[axis], nv->value_flt, GET_TEXT_ITEM(msg_units, units));
@@ -2534,7 +2534,7 @@ static void _print_pos(nvObj_t *nv, const char *format, uint8_t units)
 
 static void _print_hom(nvObj_t *nv, const char *format)
 {
-    char axes[] = {"XYZABC"};
+    char axes[] = {"XYZUVWABC"};
     uint8_t axis = _axis(nv);
     sprintf(cs.out_buf, format, axes[axis], nv->value_int);
     xio_writeline(cs.out_buf);
@prof7bit prof7bit changed the title Edge: axis names () in text mode position reports Edge: axis names in text mode position reports (contains patch) Jan 28, 2021
@jafarniknam
Copy link

Hi . I used G2core for a non-circular-turning machine . now I'm trying to write a GUI for this machine by using STM32H7B0 and a 7 inch TFT and also TouchGFX software . To have a semi-real time position monitoring , I want to use auto reported positions from status
image
my machine has 4 axes : XYZC
but auto position report of machine doesn't include C axis . is it a similar issue as you reported ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants