New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gen_tcp.erl] code smell #6

Open

tank-bohr opened this issue Jul 19, 2019 · 0 comments

Collaborator

tank-bohr commented Jul 19, 2019

<function>(S) ->
    case inet_db:lookup_socket(S) of
	{ok, Mod} ->
	    Mod:<function>(S);
	Error ->
	    Error
    end.

This pattern repeats itself all over the place. It can be replaced by a macro or a higher order function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment