New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename format related names in Address.ts #805

Open

fboucquez opened this issue Jul 26, 2021 · 0 comments

Contributor

fboucquez commented Jul 26, 2021

Atm, the naming used in the Address class is incorrect. It uses encoded when should be raw, raw when encoded plus the name "plain".

https://github.com/symbol/symbol-sdk-typescript-javascript/blob/main/src/model/account/Address.ts

The trick would be to keep the old methods with a deprecated annotation to not be a breaking change.

The rename should follow the standards in the docs symbol/symbol-docs#682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment