Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles: Select vertical alignment is slightly off #851

Closed
1 of 2 tasks
gfellerph opened this issue Dec 7, 2022 · 2 comments · Fixed by #2164
Closed
1 of 2 tasks

Styles: Select vertical alignment is slightly off #851

gfellerph opened this issue Dec 7, 2022 · 2 comments · Fixed by #2164
Assignees
@b1aserlu
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
Design - Implemen...

Comments

@gfellerph
Copy link
Member

gfellerph commented Dec 7, 2022 •
edited by b1aserlu
Loading

  • Vertical alignment is slightly off in the demo app
    image
  • Arrow size is off: Figma 15x8.5px, Demo App 14x?px. The design uses a 32x32 icon with white space (export it from figma for the right dimensions)

Originally posted by @gfellerph in #804 (comment)
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Dec 7, 2022
@gfellerph gfellerph moved this to 📋 Backlog in Design System Production Board Dec 7, 2022
@gfellerph gfellerph modified the milestones: Styles v5.1, Next Dec 7, 2022
@gfellerph gfellerph moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Feb 2, 2023
@github-actions github-actions bot added the stale label Aug 27, 2023
@gfellerph gfellerph added pibs and removed stale labels Aug 29, 2023
@gfellerph
Copy link
Member Author

gfellerph commented Aug 29, 2023 •
edited by b1aserlu
Loading

  • Check if this is still the case

@b1aserlu b1aserlu self-assigned this Sep 6, 2023
@b1aserlu b1aserlu moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Sep 6, 2023
@b1aserlu b1aserlu moved this from 🏗 In progress to 🔖 Ready in Design System Production Board Sep 12, 2023
@b1aserlu b1aserlu moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Sep 14, 2023
@b1aserlu b1aserlu moved this from 🏗 In progress to 🔖 Ready in Design System Production Board Sep 14, 2023
@b1aserlu b1aserlu removed their assignment Sep 14, 2023
@b1aserlu b1aserlu self-assigned this Oct 25, 2023
@b1aserlu b1aserlu moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Oct 25, 2023
@b1aserlu b1aserlu mentioned this issue Oct 31, 2023
Closed
@b1aserlu
Copy link
Contributor

Select is not the only component that needs its vertical allignment adjusted. This in fact concerns all the form input components.
I created this #2163 ticket to solve this

@b1aserlu b1aserlu linked a pull request Oct 31, 2023 that will close this issue
fix(styles): adjusts select Icon to match figma #2164
Merged
@b1aserlu b1aserlu moved this from 🏗 In progress to 👀 In review in Design System Production Board Oct 31, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1aserlu b1aserlu

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Design - Implementation Sync
Development

Successfully merging a pull request may close this issue.

fix(styles): adjusts select Icon to match figma swisspost/design-system
2 participants
@gfellerph @b1aserlu