Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of form-check styles #3628

Closed
3 tasks
schaertim opened this issue Oct 3, 2024 · 2 comments
Closed
3 tasks

Refactoring of form-check styles #3628

schaertim opened this issue Oct 3, 2024 · 2 comments
Labels
📦 styles Related to the @swisspost/design-system-styles package

Comments

@schaertim
Copy link
Contributor

schaertim commented Oct 3, 2024 •
edited
Loading

During the tokenisation of the form-check components I was unsure whether the styles for the switch, radio-button and checkbox should be separated (also different files?) to make them easier to understand.

Tasks
Beta Give feedback
  1. [component]: Switch #3275
    6 of 7
    📦 styles
    schaertim
  2. [component]: Radio Button (rework) #3537
    📦 styles
    schaertim
  3. [component]: Checkbox #3273
    2 of 8
    📦 styles
    schaertim
@schaertim schaertim added the 📦 styles Related to the @swisspost/design-system-styles package label Oct 3, 2024
@schaertim schaertim added this to the Cargo Components milestone Oct 3, 2024
@schaertim schaertim mentioned this issue Oct 3, 2024
Closed
@gfellerph gfellerph added needs: discussion There is at least one topic in the pattern descussion meeting about the issue needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers labels Oct 3, 2024
@gfellerph
Copy link
Member

@schaertim I would put them into separate files, this will also allow to conditionally import just one of the three.

@gfellerph
Copy link
Member

Resolution: split it up

@gfellerph gfellerph removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers labels Oct 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 Triage to 🚀 Done in Design System Production Board Oct 15, 2024
@gfellerph gfellerph removed this from the PPNL Components milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfellerph @schaertim