Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Text Input | Positive #2191

Closed
wueestd opened this issue Nov 1, 2023 · 5 comments
Closed

Component: Text Input | Positive #2191

wueestd opened this issue Nov 1, 2023 · 5 comments
Assignees
@Cian77
Labels
💚 APPROVED Review state
Milestone
Design V1

Comments

@wueestd
Copy link

wueestd commented Nov 1, 2023 •
edited by Cian77
Loading

Figma:
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=7775%3A33876&mode=design&t=VnF7Nfba4zszs6Kt-1

Story Book:
https://next.design-system.post.ch/?path=/docs/components-forms-input--docs

Comments:

  • Updated the complete component as there were quite many issues
  • Added Focus State
  • Updated new Disabled State
  • Added Documentation
@wueestd wueestd converted this from a draft issue Nov 1, 2023
@wueestd wueestd added this to the Design V1 milestone Nov 1, 2023
@Cian77 Cian77 self-assigned this Jan 5, 2024
@Cian77 Cian77 moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Jan 8, 2024
@Cian77 Cian77 changed the title Documentation: Text Input Component: Text Input Jan 8, 2024
@Cian77
Copy link

Cian77 commented Jan 8, 2024 •
edited
Loading

  • Ad Focus State and check on colours
  • Ad documentation

@Cian77 Cian77 moved this from 🏗 In progress to 👀 In review in Design System Production Board Jan 11, 2024
@Cian77
Copy link

Cian77 commented Jan 11, 2024

Hi Philipp & Rouven, the component is ready for review. By the Checkbox component, I also added the documentation for the small size. Should I do that in the same way in this component? Thanks for your Feedback.

@rouvenpost
Copy link

@Cian77 is okay from my side

@gfellerph
Copy link
Member

gfellerph commented Jan 22, 2024 •
edited
Loading

To discuss (see comments in figma):

  • Naming (Text input or Input)
  • Label boldness

@gfellerph
Copy link
Member

Looks good, added dev ticket #2527

@gfellerph gfellerph added the 💚 APPROVED Review state label Jan 24, 2024
@Cian77 Cian77 changed the title Component: Text Input Component: Text Input | Positive Feb 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cian77 Cian77

Labels
💚 APPROVED Review state
Projects
Design System Production Board
Archived in project
Milestone
Design V1
Development

No branches or pull requests
4 participants
@gfellerph @wueestd @rouvenpost @Cian77