Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update textarea styles #1834

Closed
3 tasks done
Tracked by #1837
gfellerph opened this issue Aug 21, 2023 · 3 comments · Fixed by #2857
Closed
3 tasks done
Tracked by #1837

Update textarea styles #1834

gfellerph opened this issue Aug 21, 2023 · 3 comments · Fixed by #2857
Assignees
Labels
request 📦 styles Related to the @swisspost/design-system-styles package

Comments

@gfellerph
Copy link
Member

gfellerph commented Aug 21, 2023

Textareas styling changed. There are now two size variants.

Design: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/branch/MVANE2KzNGq2et3q6T15PC/Components-Post?node-id=7779%3A34916&mode=dev

Tasks

@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package 💔 BREAKING This is a breaking change and results in a new major version labels Aug 21, 2023
@gfellerph gfellerph added request 💔 BREAKING This is a breaking change and results in a new major version and removed 💔 BREAKING This is a breaking change and results in a new major version labels Nov 6, 2023
@gfellerph
Copy link
Member Author

Breaking change is now in a separate ticket #2224

@gfellerph gfellerph added pibs and removed 💔 BREAKING This is a breaking change and results in a new major version labels Nov 6, 2023
@davidritter-dotcom davidritter-dotcom self-assigned this Nov 28, 2023
@davidritter-dotcom davidritter-dotcom moved this from 📋 Backlog to 🔖 Ready in Design System Production Board Nov 28, 2023
@davidritter-dotcom davidritter-dotcom moved this from 🔖 Ready to 🏗 In progress in Design System Production Board Nov 28, 2023
@davidritter-dotcom
Copy link
Contributor

Waiting for #1835 to be merged because there would be some conflicts.

@davidritter-dotcom
Copy link
Contributor

I encountered some issues with this ticket, that could be discussed:

  • The Label of the Input, Select and Textarea should get a smaller font-size in the small variant. I used the :has here, or should we just add a class to the label?
  • In Figma there are weird paddings like 7px at the top and no padding at the bottom, which gives four different paddings in the small variant.
  • In the select and input, there are totally different paddings and also some strange ones like the top and bottom padding of 17px on the floating select.

@davidritter-dotcom davidritter-dotcom moved this from 🏗 In progress to 👀 In review in Design System Production Board Mar 27, 2024
@oliverschuerch oliverschuerch moved this from Design in review to Development in code review in Design System Production Board Apr 23, 2024
@oliverschuerch oliverschuerch removed their assignment Jun 7, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in code review to 🚀 Ready to use (done) in Design System Production Board Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request 📦 styles Related to the @swisspost/design-system-styles package
Projects
3 participants