Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add unpkg to connect-src instruction for the icon component #1397

Closed
alizedebray opened this issue May 9, 2023 · 2 comments · Fixed by #2406
Closed

Doc: add unpkg to connect-src instruction for the icon component #1397

alizedebray opened this issue May 9, 2023 · 2 comments · Fixed by #2406
Assignees
Labels
📦 documentation Related to the @swisspost/design-system-documentation package 📦 icons Related to the @swisspost/design-system-icons package

Comments

@alizedebray
Copy link
Contributor

alizedebray commented May 9, 2023

When using the post-icon component, icons are retrieved from https://unpkg.com/ therefore the URL should be added to the connect-src in index.html. This should be aded to the documentation.

@alizedebray alizedebray added 📦 documentation Related to the @swisspost/design-system-documentation package 📦 icons Related to the @swisspost/design-system-icons package labels May 9, 2023
@oliverschuerch
Copy link
Contributor

Please ask Remy van Hoof to add this information to the blueprint.

@pazoozooCH
Copy link

I was having issues with this (I think). I couldn't get version 1.3.5 working whatever I tried (maybe a bugged version)?
With version 1.3.6, it seems to be enough to add unpkg.com to img-src, like

  <meta http-equiv="Content-Security-Policy"
        content="default-src 'none';
               script-src 'self' 'unsafe-eval';
               style-src 'self' 'unsafe-inline';
               img-src 'self' https://web.post.ch https://unpkg.com data: 'self' *.pnet.ch *.post.ch;
               connect-src 'self';
               form-action 'self';
               base-uri 'self';
               font-src 'self' https://fonts.post.ch data: 'self'">

@alizedebray , you're writing of connect-scr, is there something I'm missing?`

Cheers Martin

@github-actions github-actions bot added the stale label Aug 24, 2023
@gfellerph gfellerph removed the stale label Aug 24, 2023
@b1aserlu b1aserlu self-assigned this Dec 14, 2023
@b1aserlu b1aserlu moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Dec 14, 2023
@b1aserlu b1aserlu moved this from 🏗 In progress to 👀 In review in Design System Production Board Dec 14, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 documentation Related to the @swisspost/design-system-documentation package 📦 icons Related to the @swisspost/design-system-icons package
Projects
Development

Successfully merging a pull request may close this issue.

5 participants