From f1209cedf5594088b50d389f75f9e93406b197e4 Mon Sep 17 00:00:00 2001 From: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com> Date: Thu, 27 Jun 2024 08:26:40 +0200 Subject: [PATCH] chore: move workspace peerDependency to dependencies (#3169) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even if recommended otherwise by the stencil docs (https://stenciljs.com/docs/angular), to preven major bumps across all linked workspace packages, we need to try to move the peerDeps to deps for this one. --------- Co-authored-by: Oliver Schürch --- .changeset/olive-knives-marry.md | 5 + .../projects/components/ng-package.json | 5 +- .../projects/components/package.json | 6 +- pnpm-lock.yaml | 113 ++++++------------ 4 files changed, 47 insertions(+), 82 deletions(-) create mode 100644 .changeset/olive-knives-marry.md diff --git a/.changeset/olive-knives-marry.md b/.changeset/olive-knives-marry.md new file mode 100644 index 0000000000..d8f18762f1 --- /dev/null +++ b/.changeset/olive-knives-marry.md @@ -0,0 +1,5 @@ +--- +'@swisspost/design-system-components-angular': patch +--- + +Redefined the dependency to the web components package as a dependency instead of a peer dependency due to a [known bug in changesets](https://github.com/changesets/changesets/issues/1011) that causes major version bumps across all linked workspace packages if one of them is installed as a peer dependency. diff --git a/packages/components-angular/projects/components/ng-package.json b/packages/components-angular/projects/components/ng-package.json index 8359b8aa70..0af6765e0a 100644 --- a/packages/components-angular/projects/components/ng-package.json +++ b/packages/components-angular/projects/components/ng-package.json @@ -3,5 +3,6 @@ "dest": "../../dist/components", "lib": { "entryFile": "src/public-api.ts" - } -} \ No newline at end of file + }, + "allowedNonPeerDependencies": ["@swisspost/design-system-components"] +} diff --git a/packages/components-angular/projects/components/package.json b/packages/components-angular/projects/components/package.json index 2890665c11..e12b965df7 100644 --- a/packages/components-angular/projects/components/package.json +++ b/packages/components-angular/projects/components/package.json @@ -18,12 +18,12 @@ "linkDirectory": true }, "dependencies": { - "tslib": "2.6.3" + "tslib": "2.6.3", + "@swisspost/design-system-components": "workspace:7.1.0" }, "peerDependencies": { "@angular/common": "^16.0.0 || ^17.0.0", - "@angular/core": "^16.0.0 || ^17.0.0", - "@swisspost/design-system-components": "workspace:7.1.0" + "@angular/core": "^16.0.0 || ^17.0.0" }, "sideEffects": false } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 9a6c3ce7f2..c18971d7cb 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -3103,8 +3103,8 @@ packages: peerDependencies: tslib: '2' - '@jsonjoy.com/util@1.1.3': - resolution: {integrity: sha512-g//kkF4kOwUjemValCtOc/xiYzmwMRmWq3Bn+YnzOzuZLHq2PpMOxxIayN3cKbo7Ko2Np65t6D9H81IvXbXhqg==} + '@jsonjoy.com/util@1.2.0': + resolution: {integrity: sha512-4B8B+3vFsY4eo33DMKyJPlQ3sBMpPFUZK2dr3O3rXrOGKKbYG44J0XSFkDo1VOQiri5HFEhIeVvItjR2xcazmg==} engines: {node: '>=10.0'} peerDependencies: tslib: '2' @@ -4951,10 +4951,6 @@ packages: peerDependencies: postcss: ^8.1.0 - available-typed-arrays@1.0.5: - resolution: {integrity: sha512-DMD0KiN46eipeziST1LPP/STfDU0sufISXmjSgvVsoU2tqxctQeASejWcfNtxYKqETM1UxQ8sp2OrSBWpHY6sw==} - engines: {node: '>= 0.4'} - available-typed-arrays@1.0.7: resolution: {integrity: sha512-wvUjBtSGN7+7SjNpq/9M2Tg350UZD3q62IFZLbRAR1bSMlCo1ZaeW+BJ+D090e4hIIZLBcTDWe4Mh4jvUDajzQ==} engines: {node: '>= 0.4'} @@ -7517,10 +7513,6 @@ packages: resolution: {integrity: sha512-C/CPBqKWnvdcxqIARxyOh4v1UUEOCHpgDa0WYgpKDFMszcrPcffg5uhwSgPCLD2WWxmq6isisz87tzT01tuGhg==} engines: {node: '>= 0.4'} - is-typed-array@1.1.10: - resolution: {integrity: sha512-PJqgEHiWZvMpaFZ3uTc8kHPM4+4ADTlDniuQL7cU/UDA0Ql7F70yGfHph3cLNe+c9toaigv+DFzTJKhc2CtO6A==} - engines: {node: '>= 0.4'} - is-typed-array@1.1.13: resolution: {integrity: sha512-uZ25/bUAlUY5fR4OKT4rZQEBrzQWYV9ZJYGGsUmEJ6thodVJ1HX64ePQ6Z0qPWP+m+Uq6e9UugrE38jeYsDSMw==} engines: {node: '>= 0.4'} @@ -8293,8 +8285,8 @@ packages: resolution: {integrity: sha512-UWbFJKvj5k+nETdteFndTpYxdeTMox/ULeqX5k/dpaQJCCFmj5EeKv3dBcyO2xmkRAx2vppRu5dVG7SOtsGOzA==} engines: {node: '>= 4.0.0'} - memfs@4.9.2: - resolution: {integrity: sha512-f16coDZlTG1jskq3mxarwB+fGRrd0uXWt+o1WIhRfOwbXQZqUDsTVxQBFK9JjRQHblg8eAG2JSbprDXKjc7ijQ==} + memfs@4.9.3: + resolution: {integrity: sha512-bsYSSnirtYTWi1+OPMFb0M048evMKyUYe0EbtuGQgq6BVQM1g1W8/KIUJCCvjgI/El0j6Q4WsmMiBwLUBSw8LA==} engines: {node: '>= 4.0.0'} memoizerific@1.11.3: @@ -10227,12 +10219,6 @@ packages: resolution: {integrity: sha512-7maUZy1N7uo6+WVEX6psASxtNlKaNVMlGQKkG/63nEDdLOWNbiUMoLK7X4uYoLhQstau72mLgfEWcXcwsaHbYQ==} engines: {node: '>= 10.13.0', npm: '>= 3.0.0'} - sonic-forest@1.0.3: - resolution: {integrity: sha512-dtwajos6IWMEWXdEbW1IkEkyL2gztCAgDplRIX+OT5aRKnEd5e7r7YCxRgXZdhRP1FBdOBf8axeTPhzDv8T4wQ==} - engines: {node: '>=10.0'} - peerDependencies: - tslib: '2' - source-map-js@1.2.0: resolution: {integrity: sha512-itJW8lvSA0TXEphiRoawsCksnlf8SyvmFzIhltqAHluXd88pkCd+cXJVHTDwdCr0IzwptSm035IHQktUu1QUMg==} engines: {node: '>=0.10.0'} @@ -10730,8 +10716,8 @@ packages: resolution: {integrity: sha512-tk2G5R2KRwBd+ZN0zaEXpmzdKyOYksXwywulIX95MBODjSzMIuQnQ3m8JxgbhnL1LeVo7lqQKsYa1O3Htl7K5g==} engines: {node: '>=18'} - tree-dump@1.0.1: - resolution: {integrity: sha512-WCkcRBVPSlHHq1dc/px9iOfqklvzCbdRwvlNfxGZsrHqf6aZttfPrd7DJTt6oR10dwUfpFFQeVTkPbBIZxX/YA==} + tree-dump@1.0.2: + resolution: {integrity: sha512-dpev9ABuLWdEubk+cIaI9cHwRNNDjkBBLXTwI4UCUFdQ5xXKqNXoK4FEciw/vxf+NQ7Cb7sGUyeUtORvHIdRXQ==} engines: {node: '>=10.0'} peerDependencies: tslib: '2' @@ -11409,10 +11395,6 @@ packages: resolution: {integrity: sha512-Lhs9Pmyph0p5n5Z3mVnN0yWcbQYUAD7rbQUiMsQxOJ3T57k7RFe35SUwWMf7dsbDZks1uOmw4AecB/JMDj3v/w==} engines: {node: '>=8.15'} - which-typed-array@1.1.11: - resolution: {integrity: sha512-qe9UWWpkeG5yzZ0tNYxDmd7vo58HDBc39mZ0xWWpolAGADdFOzkfamWLDxkOWcvHQKVmdTyQdLD4NOfjLWTKew==} - engines: {node: '>= 0.4'} - which-typed-array@1.1.15: resolution: {integrity: sha512-oV0jmFtUky6CXfkqehVvBP/LSWJ2sy4vWMioiENyJLePrBO/yKyV9OyJySfAKosh+RYkIl5zJCNZ8/4JncrpdA==} engines: {node: '>= 0.4'} @@ -13754,7 +13736,7 @@ snapshots: dependencies: buffer: 6.0.3 events: 3.3.0 - glob: 10.3.15 + glob: 10.4.1 patch-package: 8.0.0 path: 0.12.7 stream: 0.0.2 @@ -13766,7 +13748,7 @@ snapshots: assert: 2.1.0 buffer: 6.0.3 events: 3.3.0 - memfs: 4.9.2 + memfs: 4.9.3 path: 0.12.7 stream: 0.0.2 util: 0.12.5 @@ -14435,7 +14417,7 @@ snapshots: jest-haste-map: 29.7.0 jest-regex-util: 29.6.3 jest-util: 29.7.0 - micromatch: 4.0.5 + micromatch: 4.0.7 pirates: 4.0.5 slash: 3.0.0 write-file-atomic: 4.0.2 @@ -14478,21 +14460,21 @@ snapshots: '@jridgewell/resolve-uri': 3.1.1 '@jridgewell/sourcemap-codec': 1.4.15 - '@jsonjoy.com/base64@1.1.2(tslib@2.6.2)': + '@jsonjoy.com/base64@1.1.2(tslib@2.6.3)': dependencies: - tslib: 2.6.2 + tslib: 2.6.3 - '@jsonjoy.com/json-pack@1.0.4(tslib@2.6.2)': + '@jsonjoy.com/json-pack@1.0.4(tslib@2.6.3)': dependencies: - '@jsonjoy.com/base64': 1.1.2(tslib@2.6.2) - '@jsonjoy.com/util': 1.1.3(tslib@2.6.2) + '@jsonjoy.com/base64': 1.1.2(tslib@2.6.3) + '@jsonjoy.com/util': 1.2.0(tslib@2.6.3) hyperdyperid: 1.2.0 - thingies: 1.21.0(tslib@2.6.2) - tslib: 2.6.2 + thingies: 1.21.0(tslib@2.6.3) + tslib: 2.6.3 - '@jsonjoy.com/util@1.1.3(tslib@2.6.2)': + '@jsonjoy.com/util@1.2.0(tslib@2.6.3)': dependencies: - tslib: 2.6.2 + tslib: 2.6.3 '@kurbar/storybook-addon-docs-stencil@8.0.0(react-dom@18.3.1(react@18.3.1))(react@18.3.1)': dependencies: @@ -14841,7 +14823,7 @@ snapshots: '@percy/logger': 1.28.7 ajv: 8.13.0 cosmiconfig: 8.2.0 - yaml: 2.4.2 + yaml: 2.4.5 '@percy/core@1.28.7': dependencies: @@ -14860,7 +14842,7 @@ snapshots: path-to-regexp: 6.2.1 rimraf: 3.0.2 ws: 8.16.0 - yaml: 2.4.2 + yaml: 2.4.5 transitivePeerDependencies: - bufferutil - supports-color @@ -17393,8 +17375,6 @@ snapshots: postcss: 8.4.38 postcss-value-parser: 4.2.0 - available-typed-arrays@1.0.5: {} - available-typed-arrays@1.0.7: dependencies: possible-typed-array-names: 1.0.0 @@ -18739,7 +18719,7 @@ snapshots: dependencies: array-buffer-byte-length: 1.0.0 arraybuffer.prototype.slice: 1.0.1 - available-typed-arrays: 1.0.5 + available-typed-arrays: 1.0.7 call-bind: 1.0.7 es-set-tostringtag: 2.0.3 es-to-primitive: 1.2.1 @@ -18759,7 +18739,7 @@ snapshots: is-regex: 1.1.4 is-shared-array-buffer: 1.0.2 is-string: 1.0.7 - is-typed-array: 1.1.10 + is-typed-array: 1.1.13 is-weakref: 1.0.2 object-inspect: 1.12.3 object-keys: 1.1.1 @@ -18775,7 +18755,7 @@ snapshots: typed-array-byte-offset: 1.0.0 typed-array-length: 1.0.4 unbox-primitive: 1.0.2 - which-typed-array: 1.1.11 + which-typed-array: 1.1.15 es-abstract@1.23.3: dependencies: @@ -19641,7 +19621,7 @@ snapshots: find-yarn-workspace-root@2.0.0: dependencies: - micromatch: 4.0.5 + micromatch: 4.0.7 findup-sync@5.0.0: dependencies: @@ -20600,14 +20580,6 @@ snapshots: dependencies: has-symbols: 1.0.3 - is-typed-array@1.1.10: - dependencies: - available-typed-arrays: 1.0.7 - call-bind: 1.0.7 - for-each: 0.3.3 - gopd: 1.0.1 - has-tostringtag: 1.0.2 - is-typed-array@1.1.13: dependencies: which-typed-array: 1.1.15 @@ -21022,7 +20994,7 @@ snapshots: jest-regex-util: 29.6.3 jest-util: 29.7.0 jest-worker: 29.7.0 - micromatch: 4.0.5 + micromatch: 4.0.7 walker: 1.0.8 optionalDependencies: fsevents: 2.3.3 @@ -21915,12 +21887,12 @@ snapshots: dependencies: fs-monkey: 1.0.3 - memfs@4.9.2: + memfs@4.9.3: dependencies: - '@jsonjoy.com/json-pack': 1.0.4(tslib@2.6.2) - '@jsonjoy.com/util': 1.1.3(tslib@2.6.2) - sonic-forest: 1.0.3(tslib@2.6.2) - tslib: 2.6.2 + '@jsonjoy.com/json-pack': 1.0.4(tslib@2.6.3) + '@jsonjoy.com/util': 1.2.0(tslib@2.6.3) + tree-dump: 1.0.2(tslib@2.6.3) + tslib: 2.6.3 memoizerific@1.11.3: dependencies: @@ -22930,7 +22902,7 @@ snapshots: semver: 7.6.0 slash: 2.0.0 tmp: 0.0.33 - yaml: 2.4.2 + yaml: 2.4.5 path-exists@3.0.0: {} @@ -24221,11 +24193,6 @@ snapshots: ip: 2.0.1 smart-buffer: 4.2.0 - sonic-forest@1.0.3(tslib@2.6.2): - dependencies: - tree-dump: 1.0.1(tslib@2.6.2) - tslib: 2.6.2 - source-map-js@1.2.0: {} source-map-loader@5.0.0(webpack@5.90.3(esbuild@0.20.1)): @@ -24839,9 +24806,9 @@ snapshots: dependencies: any-promise: 1.3.0 - thingies@1.21.0(tslib@2.6.2): + thingies@1.21.0(tslib@2.6.3): dependencies: - tslib: 2.6.2 + tslib: 2.6.3 throttle-debounce@5.0.0: {} @@ -24901,9 +24868,9 @@ snapshots: dependencies: punycode: 2.3.1 - tree-dump@1.0.1(tslib@2.6.2): + tree-dump@1.0.2(tslib@2.6.3): dependencies: - tslib: 2.6.2 + tslib: 2.6.3 tree-kill@1.2.2: {} @@ -25262,7 +25229,7 @@ snapshots: vfile-message: 4.0.2 vfile-reporter: 8.1.1 vfile-statistics: 3.0.0 - yaml: 2.4.2 + yaml: 2.4.5 transitivePeerDependencies: - supports-color @@ -25853,14 +25820,6 @@ snapshots: load-yaml-file: 0.2.0 path-exists: 4.0.0 - which-typed-array@1.1.11: - dependencies: - available-typed-arrays: 1.0.7 - call-bind: 1.0.7 - for-each: 0.3.3 - gopd: 1.0.1 - has-tostringtag: 1.0.2 - which-typed-array@1.1.15: dependencies: available-typed-arrays: 1.0.7