Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on diskette configuration #58

Closed
sveetch opened this issue Nov 5, 2024 · 2 comments
Closed

Feedback on diskette configuration #58

sveetch opened this issue Nov 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@sveetch
Copy link
Owner

sveetch commented Nov 5, 2024

Describe the bug

Projects that have upgraded to cmsplugin-blocks>=1.3.0 (currently we are pinned on v1.2.0 but the latter versions are compatibles) will have a wrong diskette definition and their dump will fail to dump.

Note: This is not a bug only related to cmsplugin-blocks, it can happen with any other app. We just only faced with cmsplugin-blocks because of some project using a more recent release.

Also there are some cms plugin apps that are not marked to depend from djangocms, so they would be ordered to be loaded before djangocms, this will lead a loading error (at least, it can lead to other problem outside of diskette). These apps are:

  • djangocms-audio
  • djangocms-video

Environment

Describe your environment:

  • Plateform: Any
  • Python version: Any
  • Bireli version: >=0.3.12

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade to cmsplugin-blocks>=1.3.0
  2. Create at least a plugin from cmsplugin-blocks (empty dump won't raise issue)
  3. Dump data
  4. Try to load data
  5. It fails on a message alike "Integrity error: ForeignKey missing"

Expected behavior

I've thought that explicit app model definition for diskette would be better but i think it would lead more often to failures than with relaxed definition (just giving the app name) for majority of apps. Sometime apps may have breaking change that bring an undesirable model but it is probably to happen more rarely than legit new models.

All app configurations should be reviewed to be relaxed and only known undesirable model should be excluded and we stop to explicitly define all app models.

Additional context

I've reported an issue on Diskette emencia/diskette#9 for a check command that would have helped to see this kind of issue.

@sveetch sveetch added the bug Something isn't working label Nov 5, 2024
@sveetch
Copy link
Owner Author

sveetch commented Dec 1, 2024

Also Diskette v0.4.0 has been released and it now involves django sendfile, its settings has to be fixed for the right paths.

@sveetch
Copy link
Owner Author

sveetch commented Dec 19, 2024

Bireli 0.4.0 includes now all fixes from feedbacks

@sveetch sveetch closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in v0.4.0 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant