Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal3 chart add upgrade CI coverage #122

Open
hardys opened this issue Apr 18, 2024 · 1 comment
Open

Metal3 chart add upgrade CI coverage #122

hardys opened this issue Apr 18, 2024 · 1 comment

Comments

@hardys
Copy link
Contributor

hardys commented Apr 18, 2024

I tried upgrading from 0.6.1 to 0.6.4 and it fails - looks like an upgrade issue related to #98 which changed the selectorLabels for each component

We need to decide if those additions are critical or can be reverted (but if we do that upgrade from 0.6.3 and 0.6.4 won't work AFAICS), and also we should consider adding CI coverage to test helm upgrade from the current to proposed release.

helm upgrade metal3 suse-edge/metal3 --version 0.6.4 --namespace metal3-system -f /home/metal3/helm-values.yaml 
Error: UPGRADE FAILED: cannot patch "baremetal-operator-controller-manager" with kind Deployment: Deployment.apps "baremetal-operator-controller-manager" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"baremetal-operator", "app.kubernetes.io/instance":"metal3", "app.kubernetes.io/name":"manger", "control-plane":"controller-manager"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable && cannot patch "metal3-metal3-ironic" with kind Deployment: Deployment.apps "metal3-metal3-ironic" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"ironic", "app.kubernetes.io/instance":"metal3", "app.kubernetes.io/name":"metal3-ironic"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable && cannot patch "metal3-metal3-mariadb" with kind Deployment: Deployment.apps "metal3-metal3-mariadb" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"mariadb", "app.kubernetes.io/instance":"metal3", "app.kubernetes.io/name":"metal3-mariadb"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
@hardys
Copy link
Contributor Author

hardys commented Apr 19, 2024

As a workaround I was able to helm uninstall then helm install and the pv data was retained using the local-path provider - I would propose that we do not revert any changes, but instead use this issue to track adding basic upgrade coverage to CI for the metal3 chart.

@hardys hardys changed the title Metal3 0.6.3 chart upgrade issue Metal3 chart add upgrade CI coverage Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant