Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-unique IDs on the homepage #102

Open
sapegin opened this issue Jun 22, 2018 · 4 comments
Open

Non-unique IDs on the homepage #102

sapegin opened this issue Jun 22, 2018 · 4 comments
Labels

Comments

@sapegin
Copy link
Member

sapegin commented Jun 22, 2018

image 2018-06-22 at 7 37 01 pm

Can we disable links on heading on the main page?

@sapegin sapegin added the bug label Jun 22, 2018
@bebraw
Copy link
Member

bebraw commented Jun 22, 2018

I have a better solution here. AnchorProvider and AnchorHeader work in pair to solve it. To integrate, it might need the same Markdown solution too.

@sapegin
Copy link
Member Author

sapegin commented Jul 3, 2018

I'd probably split book description Markdown files into two and have all heading in React. That would solve the issue for landing pages at least. We don't need these links on landing anyway.

@bebraw
Copy link
Member

bebraw commented Jul 3, 2018

Ok, splitting sounds fine.

I kind of like having headers behind some component anyway as then we can do auto-anchors and such.

@sapegin
Copy link
Member Author

sapegin commented Jul 3, 2018

Yup, if we want to. But I think it's unnecessary on marketing pages.

@sapegin sapegin mentioned this issue Jul 4, 2018
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants