Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the onSurveyPropertyValueChanged, onPropertyValidationCustomError, and onGetObjectDisplayName events #6340

Closed
tsv2013 opened this issue Dec 26, 2024 · 0 comments · Fixed by #6372
Closed

Rename the onSurveyPropertyValueChanged, onPropertyValidationCustomError, and onGetObjectDisplayName events #6340

tsv2013 opened this issue Dec 26, 2024 · 0 comments · Fixed by #6372
Assignees
@novikov82
Labels
API change Issues that request changes in the API v2.0

Comments

@tsv2013
Copy link
Member

tsv2013 commented Dec 26, 2024 •
edited by novikov82
Loading

onSurveyPropertyValueChanged -> onPropertyChanged
onPropertyValueChanging -> onPropertyChanging
onPropertyValidationCustomError -> onPropertyDisplayCustomError
onGetObjectDisplayName -> onElementGetDisplayName

onPropertyChanged:
options.element
options.name
options.value

onPropertyChanging:
options.element
options.name
options.oldValue
options.newValue
@tsv2013 tsv2013 added API change Issues that request changes in the API v2.0 labels Dec 26, 2024
@novikov82 novikov82 self-assigned this Jan 9, 2025
@RomanTsukanov RomanTsukanov changed the title SurveyCreator: renamings Rename the onSurveyPropertyValueChanged, onPropertyValidationCustomError, and onGetObjectDisplayName events Jan 9, 2025
novikov82 added a commit that referenced this issue Jan 9, 2025
@novikov82
#6340 Rename the onSurveyPropertyValueChanged, `onPropertyValidatio…
782d4e7 
…nCustomError`, and `onGetObjectDisplayName` events

Fixes #6340
@novikov82 novikov82 mentioned this issue Jan 9, 2025
Merged
novikov82 added a commit that referenced this issue Jan 11, 2025
@novikov82
fixed import, #6340
8e4fcfb
novikov82 added a commit that referenced this issue Jan 13, 2025
@novikov82
#6340 Rename the onSurveyPropertyValueChanged, `onPropertyValidatio…
d513046 
…nCustomError`, and `onGetObjectDisplayName` events

Fixes #6340
novikov82 added a commit that referenced this issue Jan 13, 2025
@novikov82
#6340 Rename the onSurveyPropertyValueChanged, `onPropertyValidatio…
90ad379 
…nCustomError`, and `onGetObjectDisplayName` events

Fixes #6340
novikov82 added a commit that referenced this issue Jan 15, 2025
@novikov82 @RomanTsukanov
#6340 Rename the onSurveyPropertyValueChanged, `onPropertyValidatio… (
1005c98 
#6372)

* #6340 Rename the `onSurveyPropertyValueChanged`, `onPropertyValidationCustomError`, and `onGetObjectDisplayName` events
Fixes #6340

* fixed import, #6340

* #6340 Rename the `onSurveyPropertyValueChanged`, `onPropertyValidationCustomError`, and `onGetObjectDisplayName` events
Fixes #6340

* Update descriptions and code

---------

Co-authored-by: RomanTsukanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novikov82 novikov82

Labels
API change Issues that request changes in the API v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6340 Rename the onSurveyPropertyValueChanged, `onPropertyValidatio… surveyjs/survey-creator
2 participants
@tsv2013 @novikov82