Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pass/fail for WCAG 1.4.11 Non-text contrast #30

Closed
lloydi opened this issue Jan 27, 2021 · 1 comment · Fixed by #35
Closed

Include pass/fail for WCAG 1.4.11 Non-text contrast #30

lloydi opened this issue Jan 27, 2021 · 1 comment · Fixed by #35
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lloydi
Copy link

lloydi commented Jan 27, 2021

Simple one really - where you have the pass/fail inidicators for text contrast, it would be good to have another row detailing pass/fail for SC 1.4.11 Non-text Contrast (Perhaps this would be enabled in prefs)

@lloydi lloydi added the enhancement New feature or request label Jan 27, 2021
@lloydi lloydi changed the title Include pass/fail for WCAG 1.4.11 Non-rext contrast Include pass/fail for WCAG 1.4.11 Non-text contrast Jan 27, 2021
@superhighfives
Copy link
Owner

Hmm, given this is the same contrast as AA large, maybe it would be easier to simply edit the copy for AA+?

A screenshot of Pika showing the help text for AA+ contrast

For example, could update it from:

- let AAPlusText = "WCAG 2 level AA requires a contrast ratio of at least 3:1 for bold or large text."
+ let AAPlusText = "WCAG 2 level AA requires a contrast ratio of at least 3:1 for bold or large text, and for non-text content like UI."

I've got an issue to better explore the iconography for the AA / AA+ / AAA / AAA+, too, which this could be a part of. #15

@superhighfives superhighfives self-assigned this Jan 28, 2021
@superhighfives superhighfives added this to the 0.0.9 milestone Feb 15, 2021
@superhighfives superhighfives linked a pull request Feb 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants