Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong color with all color formats #102

Open
dobladov opened this issue May 3, 2023 · 8 comments
Open

Wrong color with all color formats #102

dobladov opened this issue May 3, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@dobladov
Copy link

dobladov commented May 3, 2023

Describe the bug
No color format matches the real value of the color #ffb305, they are slightly different from the original.

To Reproduce

  • Select a color
  • Check the color

Expected behavior
The color should match the one selected by the tool #ffb305

Screenshots

Untitled.mp4

Environment:

  • OS: Mac OS ventura
  • App Version: 0.0.15
  • Architecture: Apple Silicon M1
@dobladov dobladov added the bug Something isn't working label May 3, 2023
@superhighfives
Copy link
Owner

Oooh, thanks for sharing a detailed example of the issue, @dobladov. A couple of follow up questions to deeper on this:

  1. Are you using Chrome? If so, if you visit chrome:///flags/#force-color-profile what does it show? (It'll most likely be Default).
  2. Do you have the same issue with RGB? Trying with the following settings I was able to pick the right colour: https://www.colorhexa.com/ffb305 (screenshot below) but I noticed in your video that it's feb rather than ffb, which is unexpected.
image
  1. Could you test with RGB and the ColorSync Utility on Mac? (another screenshot below)
image

@dobladov
Copy link
Author

dobladov commented May 9, 2023

  1. Are you using Chrome? If so, if you visit chrome:///flags/#force-color-profile what does it show? (It'll most likely be Default).

Yes, using the default, those are the other options.

Screenshot 2023-05-09 at 19 01 44
  1. Do you have the same issue with RGB? Trying with the following settings I was able to pick the right colour: https://www.colorhexa.com/ffb305 (screenshot below) but I noticed in your video that it's feb rather than ffb, which is unexpected.

Interestingly, I get almost the correct value using the same profile as you, it might be some rounding error.

Screenshot 2023-05-09 at 19 12 55

The RGB is also slightly wrong for the blue.

Screenshot 2023-05-09 at 19 15 48
  1. Could you test with RGB and the ColorSync Utility on Mac? (another screenshot below)

The colour wallpaper tool also gets a different value #FF9900, which makes me think it might be something wrong with my laptop and not Pika.
Screenshot 2023-05-09 at 19 25 41

Thanks for having a look at it.

@superhighfives
Copy link
Owner

On 3., it might be because you have web safe colours selected? 🤔

Hmmm, I wonder if it's a rounding issue, like you say. The other issue is that there's a huge number of variables in the calculator (for example, perceptual vs relative or absolute). One thing I'm interested in testing out is a package like https://github.com/sersoft-gmbh/color-components for converting colours, as I ended up adding the math directly to the app.

@michaeltroya
Copy link

@dobladov did you ever find a fix for this?

@rofrol
Copy link

rofrol commented May 25, 2024

I have similar problem.
kitty terminal.
https://github.com/sindresorhus/System-Color-Picker shows correct #6fd2fc color

Screenshot 2024-05-25 at 11 54 27

@superhighfives
Copy link
Owner

Could you try some of the different colour spaces available in the Pika preferences and see if that helps? Thanks so much. ☺️

@rofrol
Copy link

rofrol commented May 25, 2024

It shows correctly in:

  • sRGB IEC61966-2.1
  • Dell AW3418DW
  • Device RGB

By default it is in System Default (Color LCD).

Which one should I use?

@superhighfives
Copy link
Owner

I think any of the three should be fine—sRGB is a common colour profile, in my experience, if you'd like to know what you're using consistently on different devices. The other two are likely tied to your monitor, which your system default should be too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants