From 3f75fa935577ad464a6c9c08c7c7a29ed9258819 Mon Sep 17 00:00:00 2001 From: Yvan Volochine Date: Wed, 5 Jun 2019 12:12:36 +0200 Subject: [PATCH 1/2] make LadspaUGen optional but ON by default Signed-off-by: Yvan Volochine --- CMakeLists.txt | 1 + README.md | 5 ++++- source/CMakeLists.txt | 6 +++--- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index cb0248d974..2a17f512e5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -64,6 +64,7 @@ else() endif() option(AY "Build with AY ugens" ON) +option(LADSPA "Build with Ladspa ugen" ON) option(QUARKS "Install plugins as quarks") option(OSX_PACKAGE "Package dmg for Apple") option(IN_PLACE_BUILD "Build and install in cmake build folder" ON) diff --git a/README.md b/README.md index 0563d7921f..8d36d0af8d 100644 --- a/README.md +++ b/README.md @@ -83,7 +83,7 @@ ambisonics) subproject. * (default on linux `/usr/local`) * `cmake -DCMAKE_INSTALL_PREFIX=/usr/local ..` + Install in cmake build folder instead of `CMAKE_INSTALL_PREFIX` - * (OSX ONLY, default=ON) + * (macOS ONLY, default=ON) * `cmake -DIN_PLACE_BUILD=ON` + Build the plugins as quarks * (default 'OFF') @@ -91,6 +91,9 @@ ambisonics) subproject. + Build supernova-plugins * (default 'OFF') * `cmake -DSUPERNOVA=ON ..` ++ Build Ladspa UGen + * (macOS AND LINUX ONLY, default=ON) + * `sc3-plugins/build/$ cmake -DLADSPA=ON ..` + Print all cmake options * `sc3-plugins/build/$ cmake -L ..` diff --git a/source/CMakeLists.txt b/source/CMakeLists.txt index 8709638aa0..0e60a632d6 100755 --- a/source/CMakeLists.txt +++ b/source/CMakeLists.txt @@ -117,7 +117,6 @@ set(PLUGIN_DIRS_EXTRA BetablockerUGens ChaosUGens DEINDUGens - LadspaUGen MembraneUGens NCAnalysisUGens OteyPianoUGens @@ -245,7 +244,8 @@ BUILD_PLUGIN(MembraneUGens "MembraneUGens/Membrane_shape.c;MembraneUGens/Membran "" "MembraneUGens") # LadspaUGen -if(NOT WIN32) +if(LADSPA AND NOT WIN32) + list(APPEND PLUGIN_DIRS_EXTRA LadspaUGen) BUILD_PLUGIN(LadspaUGen "LadspaUGen/LadspaUGen.cpp;LadspaUGen/search.c" "${CMAKE_DL_LIBS}" "LadspaUGen") add_executable(ladspalist LadspaUGen/ladspalist.c LadspaUGen/search.c) target_link_libraries(ladspalist "${CMAKE_DL_LIBS}") @@ -359,7 +359,7 @@ if (NOT APPLE) DESTINATION ${INSTALL_DESTINATION}) endif() -if(NOT WIN32) +if(LADSPA AND NOT WIN32) install(TARGETS ladspalist DESTINATION ${INSTALL_DESTINATION_LADSPALIST}) endif() From 0f9de2827052e3a8b6c16bae1e7b1c0bec86730a Mon Sep 17 00:00:00 2001 From: Yvan Volochine Date: Thu, 6 Jun 2019 10:55:26 +0200 Subject: [PATCH 2/2] documentation: add a note about Ladspa issues Signed-off-by: Yvan Volochine --- README.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 8d36d0af8d..d8743d9b8a 100644 --- a/README.md +++ b/README.md @@ -86,10 +86,10 @@ ambisonics) subproject. * (macOS ONLY, default=ON) * `cmake -DIN_PLACE_BUILD=ON` + Build the plugins as quarks - * (default 'OFF') + * (default=OFF) * `cmake -DQUARKS=ON ..` + Build supernova-plugins - * (default 'OFF') + * (default=OFF) * `cmake -DSUPERNOVA=ON ..` + Build Ladspa UGen * (macOS AND LINUX ONLY, default=ON) @@ -99,6 +99,11 @@ ambisonics) subproject. ### Troubleshooting +#### Known issues + +**On some Linux distributions** it has been reported that Ladspa UGen could prevent SuperCollider server from booting ([sc3-plugins/#210](https://github.com/supercollider/sc3-plugins/issues/210), [sc3-plugins/#23](https://github.com/supercollider/sc3-plugins/issues/23) and [supercollider/#4421](https://github.com/supercollider/supercollider/issues/4421)). +See above how to build sc3-plugins without Ladspa if needed. + #### Build errors If you get an error while building that files are missing, it probably means that you didn't clone all the SuperCollider