-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sugar Labs boot logo #6
Comments
I am so happy that you read my blog post. I will be posting a follow-up for
that very soon, on my work with bootup screens because I felt the need to
experiment further and change the animation that comes on booting my
Xubuntu using Plymouth and bash scripting.
Follow up on more such #rediscover posts and a new terminal called Fish.
|
This actually gives me a cool new idea for contribution to Sugar Thanks a lot, James, I would be adding this to my proposal for GSoC 2018 |
@quozl I would like to take this up. |
Plymouth is not in the build, so you'll have to add it as well as configure it. (Also, while it is good you would like to take it up, we do not make reservations. What matters is the pull request. This new practice of asking for permission to work on something, perhaps in the hope of being the one who will win the task, goes against our Sugar Labs culture. If someone else solves the problem before you, in a way that is better than your solution, we'll take it gladly. 😁) |
I am really sorry @quozl, I hope you would chalk these up as beginner's mistakes. I completely understand that this is not a race and also if a solution is better than mine then I too would go for it. This won't happen again, I for one know the importance of open-source culture and would do anything to uphold it.
Oooh... That sounds challenging and equal parts fun. I am down for it. I need some help though on how to go about navigating the directory structure of Sugar when installing in the system. |
How about I dig through the docs of LFS and maybe could find more about adding Plymouth and how to go about configuring it. Seems like a good place to start, right ?. |
I feel you are speculating. Clone sugar-live-build, work out how to run it, read the documentation included, and read the documentation for the dependency Debian Live Build. Come back once you've made a build and have read the documentation, because by that stage you should have a better idea of how to proceed. |
So, I cloned sugar-live-build, gave the documentation mentioned a look. I ran the build script which ran without errors and created a build. I do have a better idea then what I had at the start. I think we need to customize the live build, make a default Plymouth theme (considering Plymouth is mentioned in the package list. Which I checked, is there) So all I have to do is to create a Plymouth script (Theme) for Sugar Labs. But add it to where I am still a little unsure. Under chroot, seems the most appropriate place. |
Also, I was thinking of adding something like this |
Sorry, I thought it was very obvious. Recommended way to change the builder;
Once you make a pull request, we'll critically review whether you've made the change in the right place. Be prepared to justify your decision. 😁 You can find icons in the various Sugar Labs repositories. Format is SVG so they can be rendered to any size. Look in |
Plymouth Script draft 1
Any changes, or should I proceed to test it. Thanks for the detailed description. It helps a ton. |
Ask sugar-devel@ for design opinions. I think it is unlikely anybody else is following this issue. |
Roger that, sending a message now. |
looks good to me... |
I have a comment, I don't know if it is doable but I think if it is possible the loader (sugarlabs image)should use the same pattern(use different colors, meaning switching different image.) just how logo change on www-sugarlabs along with the spinner. |
@vipulgupta2048, likely to take weeks to get feedback, so why not go ahead with what you have? Next step for us to review is a pull request with the implementation details. Content of logo can be changed later, separate issue. |
I finally got the build script (5th attempt) running with my config in it 😅 But then after booting the .iso made by the script in VM, this happened. I can't seem to debug this, any suggestions are appreciated. My changes to live-build are here I am still learning as I go. Also, I will straighten all the changes done, once everything is finalized. |
Common problem; there's no Unrelated to the problem; we can't have binaries like those |
Roger that, I can fix it.
That's a module needed for running the Plymouth theme, Debian doesn't have that in the Plymouth folder upon installing Plymouth. I had plans of removing it once, the .iso ran and checking again. Will take care of it. Thanks. Also, what do you think about the other changes to hooks and package-lists. Going the right way or any further changes that are needed? |
Your quoting was broken and looks wrong in GitHub. Reformatting below;
Then it should come from the Plymouth packages, right? After installing
It does have Perhaps you have used the wrong path to the file?
The commits didn't explain what was changing and why, so they were very difficult to follow. There seemed to be redundant changes to multiple directories. You might test to see what changes are required, minimise the changes, and rewrite the commit series by rebasing and adding a detailed commit message. See our guide to commit message writing. |
Fixed the quotes, thanks for mentioning. Will take care of the same.
I will surely look into it, thanks for the reference. I could be wrong there. The final commit won't have it.
As mentioned before, I have done the changes in a more unprofessional manner then I would have liked since I am still testing the build. The final review would include having all commits rebased and amended when I make the PR. I am on it. |
It would be nice to have a boot logo.
Perhaps this may help;
https://mixstersite.wordpress.com/2018/03/01/customise-boot-logo-xubuntu-discover/#more-1551
by @vipulgupta2048.
The text was updated successfully, but these errors were encountered: