Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed mode broken from 2024.06.18 #177

Open
opalrt opened this issue Jan 15, 2025 · 2 comments
Open

embed mode broken from 2024.06.18 #177

opalrt opened this issue Jan 15, 2025 · 2 comments

Comments

@opalrt
Copy link

opalrt commented Jan 15, 2025

Expected

I expect to see my embedded diagram in my local web site if I use this url:
http://localhost:8080/workspace/embed?diagram=MyDiagram

Actual

I get a error Bad Request about type of string Long type:
Failed to convert value of type 'java.lang.String' to required type 'long'; For input string: "embed"]

Steps to reproduce

  1. Just create workspace with simple example like:
    workspace { model { u = person "User" ss = softwareSystem "Software System" u -> ss "Uses" } views { systemContext ss { include * autolayout lr } } }

  2. start structurizr lite 2024.06.18 locally on port 8080

  3. try url: http://localhost:8080/workspace/embed?diagram=SystemContext-001

Version/build information

It works with 2024.03.03 but it fail from 2024.06.18 to latest.
I checked changes and it seems multi-workspace feature could be impact the embed feature.

Severity

Critical

Priority

I'm willing to pay for this fix (add details below)

More information

We use a lot structurizr lite locally to check our work before to push to the server.
We use Gitlab pages as web site server and iframe to embed diagram from Structurizr server to our documentation.
We already pay for support with opalrt account.
It is critical because our IT ask us to update to latest version for security aspect.
Thanks for your help,
Best regards.
Eric PANIER

@opalrt opalrt added the bug Something isn't working label Jan 15, 2025
@opalrt opalrt changed the title embed mode embed mode broken from 2024.06.18 Jan 15, 2025
@simonbrowndotje
Copy link
Contributor

Embedding diagrams from Lite has never been a published feature (https://docs.structurizr.com/products#comparison), and the recommendation is to publish workspaces to an on-premises installation, from which they can then be embedded via an iframe -> https://docs.structurizr.com/onpremises/embed

This feature could be added in the future, but I'd like to understand the use case for it first, since Lite is primarily designed for local authoring.

We already pay for support with opalrt account.

I may be mistaken, but I can't find a current support contract for Structurizr Lite.

@simonbrowndotje simonbrowndotje removed the bug Something isn't working label Jan 17, 2025
@opalrt
Copy link
Author

opalrt commented Jan 17, 2025

Thank you, @simonbrowndotje, for your quick response,
Sorry, but I assumed that Lite was included in our On-Premise support.
And I thought this feature was included in Lite since it was working in version 2024.03.03. I will therefore look into how to handle this on our end. We would need to embed diagrams in our local mkdocs website for our developers to get the end result locally before to push on the servers Structurizr and Gitlab pages.
Maybe I misunderstood how the embed mode of Structurizr works and its purpose...
Regards.
Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants