Cannot refresh jail time

[robstolarz]

futaba/futaba/cogs/moderation/core.py

Lines 107 to 119 in 6b30197

	def check_other_roles(self, member):
	has_other, punish_role, _ = self.bot.sql.moderation.get_other_roles(member)
	if has_other:
	embed = discord.Embed(colour=discord.Colour.red())
	role_descr = (
	""
	if punish_role is None
	else f"because they already have {punish_role.mention}"
	)
	embed.description = (
	f"Cannot add a new overriding role to {member.mention} {role_descr}"
	)
	raise CommandFailed(embed=embed)

, called from

futaba/futaba/cogs/moderation/core.py

Lines 255 to 259 in 6b30197

	if remove_other:
	self.check_other_roles(member)
	await self.bot.sql.moderation.remove_other_roles(
	member, roles.jail, full_reason
	)

, checks to make sure that someone does not already have overriding roles before applying a new set. However, because of this check, jail time cannot easily be refreshed or changed once it is set. Instead, an error like "Cannot add a new overriding role to <user> because they already have <role>" is presented.

Would it make sense to alter this check to see if the new overriding roles are the same as the old ones and, if so, allow the check to pass?

Or perhaps these functions should be merged to attempt to add the overriding roles, and fail if an override already exists and is different than the new one?

[emmiegit]

Related to #267

[emmiegit]

Checking to make sure the existing overriding role is None or the same makes sense. However modifying the actual timer is part of the linked issue.

[emmiegit]

Multiple overriding roles were added in #298. Because the core issue this card is referring to exists in #267, I am closing this as a duplicate.