Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add level filtering widget to display quests / declutter screen #2874

Closed
Codain opened this issue May 12, 2021 · 7 comments
Closed

Add level filtering widget to display quests / declutter screen #2874

Codain opened this issue May 12, 2021 · 7 comments
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@Codain
Copy link

Codain commented May 12, 2021

Use case
With the increase of indoor mapping and feature checking in SC some areas are cluttered with a lot of quests and it can be hard to focus on the level I'm in. Examples are multi level railway stations with lot of maps, terminals, boards, staircases... Repeated at different levels. I've noticed that the level is displayed in the quest when available but when I'm on second floor I don't want first floor quests to disturb me and stop me from identifying current floor quests.

Proposed Solution
Add a widget to enable/disable level filtering and select which level(s) to display. This will imply to parse level tags including scalar levels (1), level ranges (2-10) and intermediate levels (0.5).

@matkoniecz
Copy link
Member

JOSM has something similar and it appears only if there are buildings with level tag

@andrewharvey
Copy link
Contributor

Or even just short-term fix would be to sort quests by level. I did some indoor quests the other day and found myself having to keep changing levels in the elevator as some quests were hidden by quests on other levels.

JOSM has something similar and it appears only if there are buildings with level tag

For the implementation if any of the quest features contain level or level:ref tags, then show the level filter UI based on the available level:ref/level values present in the data.

@Atrate
Copy link
Contributor

Atrate commented May 12, 2021

Partially related: #1487. POIs without a level tag would also have to be handled — either displayed on all levels or not displayed at all.

@peternewman
Copy link
Collaborator

See also (which I thought I'd raised before, but evidentially not) streetcomplete/streetcomplete-mapstyle#100 regarding how they are displayed on the map. I guess this filtering could link into that and only show the ones on your level.

JOSM has something similar and it appears only if there are buildings with level tag

It's potentially more subtle and relevant if there are any level things visible on-screen. If you look around Oxford Circus there are the paths to get to the underground, with their level tags mapped, and then footpaths on the ground which don't have any tagging (which seems fair enough), we should still be able to show either a particular level of the underground, or hide all the underground stuff.

@westnordost
Copy link
Member

TBH I am not sure how helpful this really is without a full indoor rendering support. The helpfulness of this button even in JOSM is so-so.

@peternewman
Copy link
Collaborator

TBH I am not sure how helpful this really is without a full indoor rendering support.

It would mean you could hide e.g. the underground paths. IMHO it interacts with #2878 and #2373. i.e. there is a benefit for removing subways and underpasses when mapping the surface layer. But personally I wouldn't remove them entirely because I think you can still answer (some or all of those quests), although streetcomplete/streetcomplete-mapstyle#100 would help that.

I guess I'm trying to say there are other uses for this aside from indoor mapping.

@westnordost
Copy link
Member

This'll be a will not fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

6 participants