Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK CHANGE]: remove legacy adopt existing configs #739

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Jun 8, 2022

Signed-off-by: ericsyh [email protected]

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #820

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Remove adopt existing configs.

Modifications

Remove adopt existing configs.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from a team, sijie and addisonj as code owners June 8, 2022 10:29
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 8, 2022
@ericsyh ericsyh added release-sn-platform/1.6.0 and removed no-need-doc This pr does not need any document labels Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

@ericsyh:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jun 8, 2022
@ericsyh ericsyh added no-need-doc This pr does not need any document and removed doc-info-missing This pr needs to mark a document option in description labels Jun 9, 2022
@MarvinCai
Copy link
Contributor

shall we also remove all manifests related to this?

@ericsyh
Copy link
Member Author

ericsyh commented Jun 15, 2022

shall we also remove all manifests related to this?

@MarvinCai Yeah, sure. I missed it. Will update to remove manifests.

@ericsyh
Copy link
Member Author

ericsyh commented Jun 16, 2022

@MarvinCai PTAL 742b55d

@fantapsody
Copy link
Contributor

@ericsyh We may need to keep this part for a while as we have recently found that some customers are using these options.

@ericsyh ericsyh changed the title fix(sn-platform): remove legacy adopt existing configs [BREAK CHANGE]: remove legacy adopt existing configs Nov 4, 2022
@ericsyh ericsyh removed this from the sn-platform-1.8.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-change do-not-merge no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Private Cloud]: remove operator.adopt_existing config in the chart
5 participants