Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can maps be freely added to this plugin? #8

Open
danse opened this issue Jul 12, 2016 · 2 comments
Open

Can maps be freely added to this plugin? #8

danse opened this issue Jul 12, 2016 · 2 comments
Labels

Comments

@danse
Copy link

danse commented Jul 12, 2016

From what i can see here, in order to use a map with this plugin, the map needs to exist into https://github.com/stormpython/vectormap/tree/master/public/lib/jvectormap/maps. Does this approach scale? If i would open a pull request for adding an arbitrary map to that folder, would it be accepted?

@emig
Copy link
Contributor

emig commented Jul 14, 2016

@danse this approach doesn't scale, particular maps won't be of general interest. The simple solution is to fork.

@stormpython
Copy link
Owner

@danse, I second what @emig said. I tried to include general maps that most would find useful. However, since these are vector maps, it meant including the vector files which can get pretty big depending on what you want to display.

An approach that may be worth exploring is to add a plugin system for including other vector maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants