Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce http/put capability #116

Merged
merged 8 commits into from
Apr 5, 2024
Merged

feat: introduce http/put capability #116

merged 8 commits into from
Apr 5, 2024

Conversation

Gozala
Copy link
Collaborator

@Gozala Gozala commented Apr 2, 2024

Amend spec per agreements last Thursday, few notes:

  1. I end up describing ucan/conclude capability as opposed to ucan/receipt, although we could go with receipt route if it is more preferred. Either one will likely differ from where spec will end up, but current version is likely to be closer than version with ucan/receipt.
  2. await/ok in the out field may change slightly as we're discussing doing something like { 'ucan/await': ['.ok.claim', { "/": ... }] } so you could drill down deeper, however there is no agreement in UCAN WG on exact schema yet.

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are small details to wrap up

w3-blob.md Outdated
Comment on lines 166 to 167
"url": "https://r2.cloudflare.com/ipfs/bafy...",
"headers": {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we wrap this with an address key to be consistent with Allocate receipt?

w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated
Comment on lines 167 to 168
"url": "https://r2.cloudflare.com/ipfs/bafy...",
"headers": {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now realize that this is not great :/ We can iterate after, but in the world of write to anywhere where in allocate we could look async for write targets to write, we now need to know these right away. I wonder what would be the downside of just passing the content, as service will always need to validate it

w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
Gozala and others added 2 commits April 5, 2024 01:33
w3-blob.md Outdated
cmd: "/http/put"
sub: DID
args: {
content: Multihash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a Blob instead? when we receive a http/put having the blob allows us to invoke blob/accept right away. Otherwise, we need to look at state to find it out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
content: Multihash
body: Blob

Something like this you mean ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, body or Blob is good for me

w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
w3-blob.md Outdated Show resolved Hide resolved
@Gozala Gozala merged commit 9bcea77 into main Apr 5, 2024
2 checks passed
@Gozala Gozala deleted the feat/http-put branch April 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants