Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jsoniter Scala #87

Closed
baldram opened this issue Aug 23, 2020 · 4 comments
Closed

Add support for Jsoniter Scala #87

baldram opened this issue Aug 23, 2020 · 4 comments

Comments

@baldram
Copy link
Contributor

baldram commented Aug 23, 2020

To consider adding another module with support for Jsoniter Scala.

libraryDependencies += "com.stephenn" %% "scalatest-jsoniter-scala" % "0.1.0"
baldram added a commit to baldram/scalatest-json that referenced this issue Aug 23, 2020
A draft implementation for jsoniter-scala
@baldram
Copy link
Contributor Author

baldram commented Aug 23, 2020

Work in progress here. A draft implementation is already in there.

@stephennancekivell
Copy link
Owner

Hi @baldram, it looks pretty good to me.

Is there anything more you want to add or anything before opening a PR. Maybe an ignored ExampleSpec to show that the output is like.

Cheers

@baldram
Copy link
Contributor Author

baldram commented Aug 23, 2020

Hi Stephen, exactly I plan to add this ignored spec with more examples, remove a TODO to handle an empty JSON like "[]", update Readme.md. I will also add one more test to show that "null" related issue of Circe (#9) is not relevant here (this should work already).

I will add this shortly.

Cheers

@stephennancekivell
Copy link
Owner

stephennancekivell commented Aug 23, 2020 via email

baldram added a commit to baldram/scalatest-json that referenced this issue Aug 23, 2020
Improved matcher implementation.
Added additional test cases and use examples.
baldram added a commit to baldram/scalatest-json that referenced this issue Aug 23, 2020
baldram added a commit to baldram/scalatest-json that referenced this issue Aug 23, 2020
stephennancekivell pushed a commit that referenced this issue Aug 24, 2020
* Add support for Jsoniter Scala #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants