-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Jsoniter Scala #87
Comments
A draft implementation for jsoniter-scala
Work in progress here. A draft implementation is already in there. |
Hi @baldram, it looks pretty good to me. Is there anything more you want to add or anything before opening a PR. Maybe an ignored ExampleSpec to show that the output is like. Cheers |
Hi Stephen, exactly I plan to add this ignored spec with more examples, remove a TODO to handle an empty JSON like "[]", update Readme.md. I will also add one more test to show that "null" related issue of Circe (#9) is not relevant here (this should work already). I will add this shortly. Cheers |
Cool. No rush. :)
…On Sun, 23 Aug 2020, 11:20 pm Marcin Szałomski, ***@***.***> wrote:
Hi Stephen, exactly I plan to add this ignored spec with more examples,
remove a TODO to handle an empty JSON like "[]", update Readme.md. I will
also add one more test to show that "null" related issue of Circe (#9
<#9>) is not
relevant here (this should work already).
I will add this shortly.
Cheers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRPZP3Y3CK73KHOXRFMZTSCEJP7ANCNFSM4QITVR2Q>
.
|
Improved matcher implementation. Added additional test cases and use examples.
Updated build file.
To consider adding another module with support for Jsoniter Scala.
The text was updated successfully, but these errors were encountered: