Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Orders should skip payment step #303

Open
stephenmcd opened this issue Jul 26, 2016 · 3 comments
Open

Free Orders should skip payment step #303

stephenmcd opened this issue Jul 26, 2016 · 3 comments

Comments

@stephenmcd
Copy link
Owner

Eg, cart contains items that are $0, and shipping is free - in this case the payment step should be skipped.

Will involve tweaks to the structures that control the checkout steps, since one will be removed dynamically, which doesn't happen anywhere yet.

@Remiz
Copy link

Remiz commented Sep 6, 2016

Do you think this should come as an option like SHOP_DISABLE_PAYMENT_IF_ZERO or should it be skipped by default?

I noticed that if I pass an order with $0 using the Stripe payment handler, Stripe API returns an error Invalid positive integer, so I'm wondering if it should be enabled by default...

@stephenmcd
Copy link
Owner Author

Do you think this should come as an option like SHOP_DISABLE_PAYMENT_IF_ZERO

no

@Remiz
Copy link

Remiz commented Sep 7, 2016

Here is my attempt at the problem
#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants