Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 4(+) Character Keywords #12

Open
steele232 opened this issue Jan 24, 2019 · 0 comments
Open

Support 4(+) Character Keywords #12

steele232 opened this issue Jan 24, 2019 · 0 comments
Assignees

Comments

@steele232
Copy link
Owner

steele232 commented Jan 24, 2019

Right now, the convert function only supports 3-Character keywords.

We just got a new keyword added to the mapping with 4 characters, but it won't work properly until the searchAndReplaceAll function is able to search for keyword strings with 4 characters in them.

This could use a more elegant solution than adding a variable named "fourRunes" following the pattern of the earlier code (Look at lines 261-283 in convertAll.go). Presumably, the keywords will be short and I shouldn't need to add support for much larger keywords, BUT it still is a bit of a drag to be manually duplicating code to support larger and larger keywords. (Very theoretical: Think about if this repo was forked and used for a language other than Chinese, they would probably need to use many more characters than just 3 or 4!) I think I will try and make a little more elegant solution to this...

@steele232 steele232 self-assigned this Jan 24, 2019
@steele232 steele232 changed the title Support 4-Character Keywords Support 4(+) Character Keywords Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant