[RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/uniform

[anandkaranubc]

Description

This RFC proposes improving random number generation in JS benchmarks for stats/base/dists/uniform.

Context: At present, in the remaining packages, random number generation in JS benchmarks occurs inside the benchmarking loop. Since random number generation is an expensive operation, it should be moved out of the benchmarking loops and initialized beforehand to avoid interfering with the results.

When adding support, the following tasks should be completed:

1. Move random number generation out of the benchmarking loops and initialize it before the benchmarks.

2. Ensure that the generated random values use the same range as the existing values to maintain consistency.

3. Use uniform and discreteUniform from @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.

   • For example, replace ( randu() * 10.0 + EPS ) with uniform( EPS, 10.0 ).
   • Replace ceil( randu() * 10.0 + EPS ) with discreteUniform( 1, 10 ).

To provide a concrete example of what a PR implementing the desired changes should contain, see #4837 and #4955, which provide examples for using both uniform and discreteUniform.

Related Issues

#4837, #4955

Questions

No.

Other

Once the implementation is complete, you should be able to run the following make commands:

Build Native Add-on

NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/uniform/*" make install-node-addons

Run JavaScript Benchmarks

make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/uniform/*/benchmark/benchmark.js"

Run JavaScript Native Benchmarks

make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/uniform/*/benchmark/benchmark.native.js"

Note: If running benchmarks results in an error, it is likely due to the random number generators producing values where the functions are not defined. To resolve this, check the relevant benchmark files, adjust the input value ranges to ensure they remain within the domain where the functions are valid, and then rerun the benchmarks. Reference: #4955

Checklist

• I have read and understood the Code of Conduct.
• Searched for existing issues and pull requests.
• The issue name begins with RFC:.

[MunishMummadi]

I would like to work on this issue

[MunishMummadi]

All the JS Benchmarks and JS Native Benchmarks passed. But before i make a PR just letting you know that i haven't encountered any ceil( randu() * 10.0 + EPS ) with discreteUniform( 1, 10 ). code i.e ceil(randu()) within the benchmarks of uniform.

[anandkaranubc]

Thanks for working on this issue @MunishMummadi.

All the JS Benchmarks and JS Native Benchmarks passed. But before i make a PR just letting you know that i haven't encountered any ceil( randu() * 10.0 + EPS ) with discreteUniform( 1, 10 ). code i.e ceil(randu()) within the benchmarks of uniform.

That's fine.

[MunishMummadi]

If my understanding of these issues is correct based on my PR. I would love to working on more refactoring to understand the repo better.