Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1 #4982

Open
3 tasks done
anandkaranubc opened this issue Jan 31, 2025 · 0 comments
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. RFC Request for comments. Feature requests and proposed changes.

Comments

@anandkaranubc
Copy link
Contributor

Description

This RFC proposes improving random number generation in JS benchmarks for stats/base/dists/pareto-type1.

Context: At present, in the remaining packages, random number generation in JS benchmarks occurs inside the benchmarking loop. Since random number generation is an expensive operation, it should be moved out of the benchmarking loops and initialized beforehand to avoid interfering with the results.

When adding support, the following tasks should be completed:

  1. Move random number generation out of the benchmarking loops and initialize it before the benchmarks.

  2. Ensure that the generated random values use the same range as the existing values to maintain consistency.

  3. Use uniform and discreteUniform from @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.

    • For example, replace ( randu() * 10.0 + EPS ) with uniform( EPS, 10.0 ).
    • Replace ceil( randu() * 10.0 + EPS ) with discreteUniform( 1, 10 ).

To provide a concrete example of what a PR implementing the desired changes should contain, see #4837 and #4955, which provide examples for using both uniform and discreteUniform.

Related Issues

#4837, #4955

Questions

No.

Other

Once the implementation is complete, you should be able to run the following make commands:

Build Native Add-on

NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/pareto-type1/*" make install-node-addons

Run JavaScript Benchmarks

make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/pareto-type1/*/benchmark/benchmark.js"

Run JavaScript Native Benchmarks

make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/pareto-type1/*/benchmark/benchmark.native.js"

Note: If running benchmarks results in an error, it is likely due to the random number generators producing values where the functions are not defined. To resolve this, check the relevant benchmark files, adjust the input value ranges to ensure they remain within the domain where the functions are valid, and then rerun the benchmarks. Reference: #4955

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@anandkaranubc anandkaranubc added RFC Request for comments. Feature requests and proposed changes. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Development

No branches or pull requests

1 participant