Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/dfill to follow current project conventions #1434

Closed
3 tasks done
kgryte opened this issue Mar 1, 2024 · 2 comments · Fixed by #1455
Closed
3 tasks done

[RFC]: refactor blas/ext/base/dfill to follow current project conventions #1434

kgryte opened this issue Mar 1, 2024 · 2 comments · Fixed by #1455
Assignees
@Snehil-Shah
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@kgryte
Copy link
Member

kgryte commented Mar 1, 2024

Description

This RFC proposes refactoring @stdlib/blas/ext/base/dfill to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. Native Addons Issue involves or relates to Node.js native add-ons. Accepted RFC feature request which has been accepted. Good First Issue A good first issue for new contributors! BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. labels Mar 1, 2024
@Snehil-Shah
Copy link
Member

@kgryte Can I work on this?

@kgryte
Copy link
Member Author

kgryte commented Mar 2, 2024

Thanks for volunteering to work on this @Snehil-Shah. Feel free to submit a PR implementing the refactoring.

@Snehil-Shah Snehil-Shah mentioned this issue Mar 2, 2024
Merged
1 task
kgryte added a commit that referenced this issue Mar 3, 2024
@Snehil-Shah @kgryte
refactor: update blas/ext/base/dfill to follow current project conv…
2675d58 
…entions

Closes: #1434
Ref: #1152
PR-URL: 	#1455
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
PoookieCoder pushed a commit to PoookieCoder/stdlib that referenced this issue Mar 7, 2024
@Snehil-Shah @kgryte
refactor: update blas/ext/base/dfill to follow current project conv…
ad90536 
…entions

Closes: stdlib-js#1434
Ref: stdlib-js#1152
PR-URL: 	stdlib-js#1455
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Snehil-Shah Snehil-Shah

Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/dfill to follow current project conventions Snehil-Shah/stdlib
2 participants
@kgryte @Snehil-Shah