You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We want all goroutines to use defer common.LogOnPanic(). Otherwise it's difficult to trace the panic on mobile.
To force this, we need a PR level check that will ensure that all goroutines use this logging.
This doesn't seem to be an urgent task, yet not good to postpone.
I was curious to do it, so I used my time off for it. Results are in feat/LogOnPanic-linter branch.
Though we can change waku code. Not sure what's the way to go here.
Maybe only print the directories that were given as input?
Which repo?
We have the same check in waku repo, so we might want to extract this app to a separate repo. Or even wrap it into a Gihub Action right away, to be easily used in both repos.
Description
We want all goroutines to use
defer common.LogOnPanic()
. Otherwise it's difficult to trace the panic on mobile.To force this, we need a PR level check that will ensure that all goroutines use this logging.
More details here on implementation here:
The text was updated successfully, but these errors were encountered: